Expose funs#70
Merged
Merged
Conversation
Collaborator
Author
|
Depends on rdaly525/coreir#702 |
leonardt
approved these changes
Feb 28, 2019
Owner
leonardt
left a comment
leonardt
left a comment
There was a problem hiding this comment.
LGTM, good to merge modulo minor nitpick about assert->typeerror
|
|
||
|
|
||
| def inline_instance(instance): | ||
| assert isinstance(instance,Instance) |
Owner
There was a problem hiding this comment.
Can we make this raise a TypeError? If you have time, a more general solution might be to create a simple decorator in a file util.py which we can use to type check functions like this, like @typecheck(<expected_types>...).
Alternatively, I think we could annotate the type using Python 3 syntax, and use mypy to do it.
But a simple if <cond>: raise TypeErrror will work fine.
| for i in range(5): | ||
| inst = top_def.instances[0] | ||
| coreir.inline_instance(inst) | ||
| assert num_instances() == 6+i |
Owner
|
Can you rerun the build after you make a new release of coreir with the new C-API methods? Should be good to merge/release after that. |
Collaborator
Author
|
@leonardt Passes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the following functions:
inline_instance
module.params
context.new_namespace