Skip to content

Fix several issue for gitlab#74

Merged
leonhartX merged 1 commit intomasterfrom
support-gitlab
Apr 9, 2018
Merged

Fix several issue for gitlab#74
leonhartX merged 1 commit intomasterfrom
support-gitlab

Conversation

@leonhartX
Copy link
Copy Markdown
Owner

  • fix attach token for request
  • remove OTP since it's not supported
  • support to create/sync project(repo) under group(org)
  • refactoring and formatting

Comment thread options/options.js
});
});
})
.fail(err => {
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ ‘err’ is defined but never used.

Comment thread options/options.js
})
});
})
.fail(err => {
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ ‘err’ is defined but never used.

Comment thread src/scm/gitlab.js
this.namesToIds.groups = groups.reduce((obj, item) => (obj[item.name] = item.id, obj), {});
return this.namespaces;
})
.catch((err) => {
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ ‘err’ is defined but never used.

@leonhartX
Copy link
Copy Markdown
Owner Author

1 Warning
⚠️ manifest is not changed, forget to bump version?

Generated by 🚫 Danger

Comment thread src/scm/gitlab.js
.catch((err) => {
throw new Error('Failed to create new repository.');
});
.catch((err) => {
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ ‘err’ is defined but never used.

@leonhartX leonhartX merged commit 877268b into master Apr 9, 2018
@leonhartX leonhartX deleted the support-gitlab branch April 9, 2018 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant