TitleBar Icon is missing

[KnoerleMan]

Describe the bug

For me the Icon of the TitleBar is not shown when running the latest MVVM sample project.

I had to adjust the code from this:

<ui:TitleBar
            Title="{Binding ViewModel.ApplicationTitle, Mode=OneWay}"
            Grid.Row="0"
            Icon="pack://application:,,,/Assets/applicationIcon-256.png" />

To this:

<ui:TitleBar
            Title="{Binding ViewModel.ApplicationTitle, Mode=OneWay}"
            Grid.Row="0">
            <ui:TitleBar.Icon>
                <ui:ImageIcon>
                    <ui:ImageIcon.Source>
                        <BitmapImage UriSource="pack://application:,,,/Assets/applicationIcon-256.png" />
                    </ui:ImageIcon.Source>
                </ui:ImageIcon>
            </ui:TitleBar.Icon>
        </ui:TitleBar>

To make it work.

Does the samples need to be adjusted or am I doing something wrong?

Thanks in advance!

Regards,
Manuel

To Reproduce

Build and run the latest MVVM sample project.

Expected behavior

The window of the MVVM sample project displays the application icon in the title bar.

Screenshots

No response

OS version

Windows 10

.NET version

net8.0-windows

WPF-UI NuGet version

4.0.0

Additional context

No response

[chucker]

Looks like this worked in 2.1.0 and broke in 3.0.0. I think this change was (sort of) intentional. In 2.x, Icon is an ImageSource, which is why you can directly assign a URL. In 3.0 and beyond, it's an IconElement, which is intended for things like Icon="{ui:SymbolIcon Symbol=Star24}".

@pomianowski do we want IconElementConverter to support taking a URL that will get passed to ImageSource instead?

[Koichi-Kobayashi]

Hello, @KnoerleMan
I do the same.

        <ui:TitleBar
            x:Name="TitleBar"
            Title="{helpers:LocalizationHelperExtension Settings}"
            Grid.Row="0"
            Panel.ZIndex="1000"
            CloseWindowByDoubleClickOnIcon="True"
            ShowMaximize="True"
            ShowMinimize="True">
            <ui:TitleBar.Icon>
                <ui:ImageIcon Source="pack://application:,,,/Assets/Icon/xxx.ico" />
            </ui:TitleBar.Icon>
        </ui:TitleBar>

It is also set in the Icon property of FluentWindow.
I think this one is affecting the task tray icon.