feat(controls): Implement SpinButtonPlacementMode.Compact for NumberBox#1709
Merged
pomianowski merged 5 commits intolepoco:mainfrom May 4, 2026
Merged
Conversation
1 task
|
Thanks for doing it, in the end i never found the time |
SpinButtonPlacementMode.Compact for NumberBox
pomianowski
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NumberBoxalready had aSpinButtonPlacementMode.Compact; however, it previously had the same effect asHidden. This adds a style to NumberBox that will:It also expands Gallery's
NumberBoxPageto let users try out the three variants.Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: fixes #1673
What is the new behavior?
SpinButtonPlacementMode.Compactnow has its own look/behavior.Other information
The result roughly matches the look+feel in WinUI 3 Gallery 2.9.0.0:
Minor differences: