fix: remove Display requirement from FromServerFnError
#3847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
Author
|
@sabify Ah, if your PR is accepted, we can close this one. I'll leave it open for now, just in case, but yeah, if the |
Collaborator
|
Merged #3848, so this should be all good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I lamented @ #3811 (review) I find the returned requirement of
Displayon allFromServerFnErrorimplementations problematic. It turns out that it's there only so thatto_string()can be called in a few places where web sockets are involved.Since I don't use websockets and I don't ever display error messages "verbatim" to my end users, this
Displayrequirement is just extra churn and noise for me.We don't necessarily have to go with the exact solution I've provided here, but I'm opening this PR to at least "force" a discussion on the matter.