Phase 2 Cores#105
Merged
Merged
Conversation
New systems: A2600, A5200, A800, A7800, LYNX, WS, WSC, SGX, VEC, GW, NEOCD, N64, PSP, DC. Includes button mappings optimized for handheld devices, BIOS requirements with MD5 hashes, and default Roms/Bios/Saves folders with documentation.
common. In these cases handled by us intead of the core. We support zip and 7z for all systems.
There was a problem hiding this comment.
Pull request overview
This PR adds support for Phase 2 emulator cores, including Atari systems (2600, 5200, 7800, Lynx), Bandai systems (WonderSwan/Color), and Neo Geo CD. It also improves rendering logic, enhances logging, removes auto-generated configuration files, and adds comprehensive documentation for analog input handling.
- Adds 7 new emulator cores with complete configuration and BIOS documentation
- Improves rendering buffer selection logic to support both direct and scaled rendering modes
- Enhances logging to provide more detailed core and renderer information
Reviewed changes
Copilot reviewed 99 out of 113 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| workspace/miyoomini/platform/platform.c | Updates rendering logic to correctly select buffer based on direct vs scaled mode |
| workspace/all/player/player.c | Improves core AV info logging with more comprehensive details |
| workspace/all/common/render_sdl2.c | Adds SDL2 renderer info logging for debugging |
| workspace/all/paks/Emus/cores.json | Adds 7 new core definitions: A2600, A5200, A7800, LYNX, WS, WSC, NEOCD |
| workspace/all/paks/Emus/configs/base/*.cfg | Updates button mappings for new cores and fixes NG/NEOCD configs |
| workspace/all/paks/Emus/configs//default.cfg | Adds platform-specific scaling configs for new cores, removes old auto-generated configs |
| workspace/all/paks/Emus/Makefile | Updates cores version to 20251220-2 |
| skeleton/BASE/Saves/* | Adds save directories for new systems |
| skeleton/BASE/Bios/* | Adds BIOS directories with about.txt documentation |
| scripts/generate-scaling-configs.py | Updates fill threshold and adds new cores to scaling calculation |
| scripts/calculate-buffer-scale.py | Corrects A5200 core name reference |
| docs/cores.md | Updates cores version reference |
| docs/cores-research.md | Updates core documentation and removes obsolete entries |
| docs/analog-input.md | Adds comprehensive documentation on analog input architecture |
| tests/unit/all/launcher/test_directory_utils.c | Adds test case for about.txt file handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add additional cores, test, and simplify based on results.