Fix thumbnail cache dangling pointer bug#63
Merged
Conversation
Refactored cache into encapsulated ThumbCache struct that tracks the displayed item and auto-invalidates on eviction. Surfaces are now looked up fresh each frame instead of storing pointers that can go stale. Also fixed preloading to trigger on cache hits.
There was a problem hiding this comment.
Pull request overview
This PR refactors the thumbnail cache to fix dangling pointer bugs by introducing an encapsulated ThumbCache struct that tracks the displayed item and auto-invalidates on eviction. The refactoring replaces raw array manipulation with a clean API that prevents storing stale surface pointers and ensures surfaces are looked up fresh each frame.
Key Changes:
- Introduced
ThumbCacheandThumbCacheItemstructs with dedicated accessor functions - Added automatic tracking of the displayed item with eviction detection
- Fixed preloading to trigger on cache hits (not just cache misses)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored cache into encapsulated ThumbCache struct that tracks the displayed item and auto-invalidates on eviction. Surfaces are now looked up fresh each frame instead of storing pointers that can go stale. Also fixed preloading to trigger on cache hits.