fix: resolve CJK composition bug on iOS terminals (backspace packet splitting)#94
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this is needed
iOS terminal apps such as Moshi and Blink send CJK (Chinese, Japanese, Korean) composed characters in a single TCP packet when the iOS keyboard composes syllables. For example, when a user types the Korean syllable "가" followed by "나", the terminal may transmit the byte sequence:
The current
handleDatainuseTerminalInput.tspasses the entire concatenated buffer toparseTerminalInput()without splitting. SinceparseTerminalInputtreats the whole string as a single input event, the intermediate backspace (\x7f) is not interpreted as a delete action, and the composed character sequence gets corrupted. This results in garbled text and broken CJK input on iOS terminals.This is a long-standing, well-known issue affecting CJK users of Node.js TUI applications.
What was changed
In
src/ui/prompt/useTerminalInput.ts, thehandleDatafunction now detects packets that contain one or more\x7f(backspace) bytes alongside other characters. When such a combined packet is received:\x7f.parseTerminalInput()and the input handler, in order:Normal input (without embedded backspaces) follows the original code path with zero overhead.
Before
After
Testing
npm run typecheckpasses with no errors.eslint --fixandprettier --writepass via pre-commit hooks.