Add certificate lifetime configuration option#361
Merged
aarongable merged 6 commits intoletsencrypt:masterfrom Aug 24, 2021
Merged
Add certificate lifetime configuration option#361aarongable merged 6 commits intoletsencrypt:masterfrom
aarongable merged 6 commits intoletsencrypt:masterfrom
Conversation
This was referenced Aug 22, 2021
aarongable
reviewed
Aug 23, 2021
Contributor
aarongable
left a comment
There was a problem hiding this comment.
Of the three mechanisms you've proposed for making this configurable, I like this approach by far the best. Just a few small comments (nothing substantive, mostly naming nits and slight simplifications) and this'll be ready to go!
aarongable
previously approved these changes
Aug 23, 2021
Contributor
Author
|
Hm, not sure if you'd see my latest comment above, so I'll repeat it here:
Which results in this: |
aarongable
approved these changes
Aug 23, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An alternative to #353, probably not necessary to add both 😛