Merged
Conversation
…support for multiple audio files per corpus item
asengupta3
reviewed
Nov 24, 2025
| pageStateHandler = new PageStateHandler(stim.audioFile, playAudioOnLoad); | ||
| } else { | ||
| throw new Error('Multiple audio files are not supported in this trial type'); | ||
| } |
Collaborator
There was a problem hiding this comment.
You can reformat this to:
if (typeof stim.audioFile !== 'string') {
throw new Error('Multiple audio files are not supported in this trial type');
}
const pageStateHandler = new PageStateHandler(stim.audioFile, playAudioOnLoad);
asengupta3
reviewed
Nov 24, 2025
Collaborator
asengupta3
left a comment
asengupta3
left a comment
There was a problem hiding this comment.
I think some of this PR reuses the logic from the other PRs, let's merge those and then clean this PR up? It might be easier to review that way?
Collaborator
Author
Yeah that sounds good! It uses parts of the matrix reasoning changes - I just merged that PR, so I'll merge main into this branch and fix the conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds new instructions for younger kids only with button animations based on this doc: https://docs.google.com/document/d/16ejc06AKF_nraSk5io8wegHaSbkK3OF6ALKLusSnjgg/edit?usp=sharing