Stop mental rotation and matrix cat if 4 of last 10 trials are incorrect#409
Stop mental rotation and matrix cat if 4 of last 10 trials are incorrect#409zwatson2001 merged 2 commits intomainfrom
Conversation
|
|
||
| // ends the task if 4 of the last 10 trials have been incorrect | ||
| export function checkCatStopping() { | ||
| const data = jsPsych.data.get().filter({assessment_stage: 'test_response'}).last(10); |
There was a problem hiding this comment.
Do you think we need to filter anything else other than test_response? I haven't looked at the corpuses in a while and am wondering if there are others we introduced that don't count in checking for correctness.
There was a problem hiding this comment.
Every trial that counts for scoring should have test_response for both matrix reasoning and mental rotation, so I think this should be okay (it will filter out any practice or instructions)
There was a problem hiding this comment.
I think that task/ column standardization will help. It will be much easier to document
| promptAboveButtons: true, | ||
| task: config.task, | ||
| layoutConfigMap, | ||
| catStopping: runCat, // if running cat, stop if 4 of last 10 trials have been incorrect |
There was a problem hiding this comment.
I would rename catStopping to terminateCat.
| import { finishExperiment } from "../trials/finishExperiment"; | ||
|
|
||
| // ends the task if 4 of the last 10 trials have been incorrect | ||
| export function checkCatStopping() { |
There was a problem hiding this comment.
rename to shouldTeminateCat?
Linked to #408