Skip to content

Stop mental rotation and matrix cat if 4 of last 10 trials are incorrect#409

Merged
zwatson2001 merged 2 commits intomainfrom
update-cat-stopping-rule
Jan 21, 2026
Merged

Stop mental rotation and matrix cat if 4 of last 10 trials are incorrect#409
zwatson2001 merged 2 commits intomainfrom
update-cat-stopping-rule

Conversation

@zwatson2001
Copy link
Copy Markdown
Collaborator

Linked to #408

@zwatson2001 zwatson2001 requested a review from asengupta3 January 5, 2026 16:07

// ends the task if 4 of the last 10 trials have been incorrect
export function checkCatStopping() {
const data = jsPsych.data.get().filter({assessment_stage: 'test_response'}).last(10);
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we need to filter anything else other than test_response? I haven't looked at the corpuses in a while and am wondering if there are others we introduced that don't count in checking for correctness.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every trial that counts for scoring should have test_response for both matrix reasoning and mental rotation, so I think this should be okay (it will filter out any practice or instructions)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that task/ column standardization will help. It will be much easier to document

promptAboveButtons: true,
task: config.task,
layoutConfigMap,
catStopping: runCat, // if running cat, stop if 4 of last 10 trials have been incorrect
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rename catStopping to terminateCat.

import { finishExperiment } from "../trials/finishExperiment";

// ends the task if 4 of the last 10 trials have been incorrect
export function checkCatStopping() {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to shouldTeminateCat?

Copy link
Copy Markdown
Collaborator

@asengupta3 asengupta3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zwatson2001 zwatson2001 merged commit 2af66f4 into main Jan 21, 2026
3 checks passed
@zwatson2001 zwatson2001 deleted the update-cat-stopping-rule branch January 21, 2026 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants