search example from README doesn't work#9
Merged
elf-pavlik merged 1 commit intolevelgraph:masterfrom Dec 9, 2013
Merged
Conversation
Collaborator
|
I've just checked. Something weird is going on, but I'm not sure what. It is supposed to return all friend of 'person' named 'Daniele'. |
Member
Author
|
oh... in second part of join in predicate |
Collaborator
|
Oooh, right! GOSH. Thanks a million!! |
Collaborator
|
Daniele is a friend of mine (@dbottillo). I just hope he is not upset I used his name all over the place :P. |
Collaborator
|
Fix it, then! |
Member
Author
|
i made an example search based on what i regularly look for, nowadays still using faceboogle... |
Collaborator
|
Can I merge? |
Collaborator
|
Or better, merge if you think it's fine. 👍 for me. |
elf-pavlik
pushed a commit
that referenced
this pull request
Dec 9, 2013
search example from README doesn't work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I try to run it I get empty array in solutions... we need to make sure that we put in README only exact examples from test suite!
While not that familiar with LevelGraph joins I also don't find it obvious what exactly we search for here, adding one sentence about intended results will make it clearer for everyone.