Skip to content

n-triple data import tool#15

Merged
transcranial merged 6 commits intolevelgraph:masterfrom
transcranial:master
Apr 8, 2015
Merged

n-triple data import tool#15
transcranial merged 6 commits intolevelgraph:masterfrom
transcranial:master

Conversation

@transcranial
Copy link
Copy Markdown

re: issue #9

@mcollina
Copy link
Copy Markdown
Collaborator

@elf-pavlik what do you think?

I will merge this and add @transcranial as a contributor, it it is ok for you too!

@elf-pavlik
Copy link
Copy Markdown
Member

@transcranial can you think of some automated tests you could add to this PR?

@transcranial
Copy link
Copy Markdown
Author

@elf-pavlik wrote some tests, please take a look!

@elf-pavlik
Copy link
Copy Markdown
Member

Thanks!
@mcollina looks good for me to merge and yes please add @transcranial as contributor :)

Comment thread import.js Outdated
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This finally block is not going to work, as you should listen for the end of the import stream.

I recommend the use of eos to detect it.

@mcollina
Copy link
Copy Markdown
Collaborator

mcollina commented Apr 6, 2015

Once that little fix is solved, @elf-pavlik feel free to merge this and release it as 0.5.0 :).

@elf-pavlik
Copy link
Copy Markdown
Member

@mcollina why do we need to bump version from 0.4.0 to 0.5.0 ?

@mcollina
Copy link
Copy Markdown
Collaborator

mcollina commented Apr 6, 2015

It's a new feature, so a minor bump is ok :). Patch releases are for bugfixes.

@transcranial
Copy link
Copy Markdown
Author

@elf-pavlik @mcollina thanks for the catch! Fixed.

@mcollina
Copy link
Copy Markdown
Collaborator

mcollina commented Apr 6, 2015

Should we also bump n3 to 0.4.x?

transcranial added a commit that referenced this pull request Apr 8, 2015
@transcranial transcranial merged commit 434a979 into levelgraph:master Apr 8, 2015
@elf-pavlik
Copy link
Copy Markdown
Member

published v0.5.0 to NPM! thanks a lot @transcranial 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants