-
Notifications
You must be signed in to change notification settings - Fork 0
feat: display all logs that step scripts make in CI logs #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
encourages users to write logs. debug logs should only be valuable to devs of this tool, not to view your own logs you make when using this tool.
decafRunning deployments in test mode. Results will appear below. ...🟩 merge 🟩 merge method... 🚢 The next version of the project will be: 0.2.0 Learn moreLatest release: 0.1.1 Commit of latest release: 642f275 Commits since last release: - Merge pull request #80 from debug-logs - fix: avoid duplicate log entries in the debug write file In the debug log file, credit and CI server, I'm seeing some commands are displaying the standard out multiple times still. when you view debug logs, the shell command stdouts are shown multiple times. There are design patterns that have already been established for running the other step scripts. So the fact that we have a separate block of code that is only for running the deploy step script doesn't make any sense. Make the code more maintainable by moving it into the step runner, but also allow me to continue following all the same design patterns that need to be followed for all running of step scripts. turns out, stdout is logged multiple times. pretty annoying when viewing in CI and causing confusion to me. encourages users to write logs. debug logs should only be valuable to devs of this tool, not to view your own logs you make when using this tool. decafRunning deployments in test mode. Results will appear below. ...🟩 squash 🟩 merge method... 🚢 The next version of the project will be: 0.2.0 Learn moreLatest release: 0.1.1 Commit of latest release: 642f275 Commits since last release: - feat: display all logs that step scripts make in CI logs Related GitHub IssuesProblemWhenever you open a pull request and you view the test mode logs and you see a result that you did not expect, the the next thing you do is go into the CI and start looking at the logs. The problem is the debug logs contain the information you need to figure out if this is an issue with your step script or if it's an issue with the tool, and I don't think you need to use the debug logs. To determine that, you should be able to View the non-debug logs as a user. and figure out everything that you need. You only should have to use the debug logs to figure out bugs in this tool. This is especially important because debug logs right now are extremely verbose and I think that's valuable but only if you are a developer of this tool. Solution
Testing
View the logs from this PR. See if logs in the scripts are shown. Notes for reviewersdecafRunning deployments in test mode. Results will appear below. ...🟩 rebase 🟩 merge method... 🚢 The next version of the project will be: 0.2.0 Learn moreLatest release: 0.1.1 Commit of latest release: 642f275 Commits since last release: - fix: avoid duplicate log entries in the debug write file In the debug log file, credit and CI server, I'm seeing some commands are displaying the standard out multiple times still. when you view debug logs, the shell command stdouts are shown multiple times. There are design patterns that have already been established for running the other step scripts. So the fact that we have a separate block of code that is only for running the deploy step script doesn't make any sense. Make the code more maintainable by moving it into the step runner, but also allow me to continue following all the same design patterns that need to be followed for all running of step scripts. turns out, stdout is logged multiple times. pretty annoying when viewing in CI and causing confusion to me. encourages users to write logs. debug logs should only be valuable to devs of this tool, not to view your own logs you make when using this tool. |
Pull Request Test Coverage Report for Build 17068274896Details
💛 - Coveralls |
turns out, stdout is logged multiple times. pretty annoying when viewing in CI and causing confusion to me.
There are design patterns that have already been established for running the other step scripts. So the fact that we have a separate block of code that is only for running the deploy step script doesn't make any sense. Make the code more maintainable by moving it into the step runner, but also allow me to continue following all the same design patterns that need to be followed for all running of step scripts.
…bug logs when they encounter issues
…logs when you view debug logs, the shell command stdouts are shown multiple times.
In the debug log file, credit and CI server, I'm seeing some commands are displaying the standard out multiple times still.
Related GitHub Issues
Problem
Whenever you open a pull request and you view the test mode logs and you see a result that you did not expect, the the next thing you do is go into the CI and start looking at the logs. The problem is the debug logs contain the information you need to figure out if this is an issue with your step script or if it's an issue with the tool, and I don't think you need to use the debug logs. To determine that, you should be able to View the non-debug logs as a user. and figure out everything that you need. You only should have to use the debug logs to figure out bugs in this tool.
This is especially important because debug logs right now are extremely verbose and I think that's valuable but only if you are a developer of this tool.
Solution
debug_fileoptional command line argument to send logs to a file. Useful to capture debug logs to send to us.Testing
View the logs from this PR. See if logs in the scripts are shown.
Notes for reviewers