proposal: Extracting/injecting trace info from/to headers#24
Merged
danslapman merged 1 commit intoleviysoft:mainfrom Dec 14, 2023
Merged
Conversation
ashashev
changed the title
ashashev
force-pushed
the
chore/extract-inject-trace-info
branch
from
753cf28 to
f724828
Compare
ashashev
force-pushed
the
chore/extract-inject-trace-info
branch
from
f724828 to
3fed19a
Compare
danslapman
reviewed
Dec 10, 2023
|
|
||
| object GrpcRequestHandler { | ||
| object keys { | ||
| val correlationId = io.grpc.Metadata.Key.of("X-Correlation-ID", io.grpc.Metadata.ASCII_STRING_MARSHALLER) |
Member
There was a problem hiding this comment.
I think these fields should be configurable as well
Contributor
Author
There was a problem hiding this comment.
OK, I will add separate config for it.
Contributor
Author
There was a problem hiding this comment.
Oh, it's from previous changes. It is not actual for now. I misunderstood you. Now HTTP and gRPC have the same configuration, see file backend/mockingbird/src/main/scala/ru/tinkoff/tcb/mockingbird/api/Tracing.scala line 20. So, I will delete object keys, because it is unused.
Contributor
Author
There was a problem hiding this comment.
Removed, tracing for gRPC and HTTP have the same configuration. If you think that adding the separate config for extracting/injecting gRPC I will do it.
danslapman
requested changes
Dec 10, 2023
Member
danslapman
left a comment
danslapman
left a comment
There was a problem hiding this comment.
GRPC headers should be configurable as well
ashashev
force-pushed
the
chore/extract-inject-trace-info
branch
from
3fed19a to
ab1b54f
Compare
Adding extracting tracing info from headers of HTTP and gRPC calls and
adding them to response headers.
The configuration example:
```
{
"tracing": {
"required": ["correlationId", "traceId"],
"incomingHeaders": {
"X-Trace-ID": "traceId",
"X-Request-ID": "traceId"
},
"outcomingHeaders": {
"correlationId": "X-Correlation-ID",
"traceId": "X-Trace-ID"
}
}
}
```
The required field contains the list of obligated tracing fields.
These fields always exist, it means when a client calls, the
mockingbird generates for these fields unique ID (UUID).
The incomingHeaders set matching between request headers that contain
tracing info and tracing field on the Mockingbird side. Comparing the
headers is case-insensitive. For the config above, if request contains
"X-Trace-ID" or "X-Request-ID", its value overrides generated value of
traceId field.
The outcomingHeaders specified which tracing fields should be returned
in response headers.
ashashev
force-pushed
the
chore/extract-inject-trace-info
branch
from
7825248 to
2067157
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding extracting tracing info from headers of HTTP and gRPC calls and adding them to response headers.
The configuration example:
{ "tracing": { "required": ["correlationId", "traceId"], "incomingHeaders": { "X-Trace-ID": "traceId", "X-Request-ID": "traceId" }, "outcomingHeaders": { "correlationId": "X-Correlation-ID", "traceId": "X-Trace-ID" } } }The required field contains the list of obligated tracing fields. These fields always exist, it means when a client calls, the mockingbird generates for these fields unique ID (UUID).
The incomingHeaders set matching between request headers that contain tracing info and tracing field on the Mockingbird side. Comparing the headers is case-insensitive. For the config above, if request contains "X-Trace-ID" or "X-Request-ID", its value overrides generated value of traceId field.
The outcomingHeaders specified which tracing fields should be returned in response headers.
@mockingbird/maintainers