Skip to content

Fix the verbose flag#115

Merged
JoelLefkowitz merged 1 commit intomasterfrom
bug/verbose
Mar 23, 2025
Merged

Fix the verbose flag#115
JoelLefkowitz merged 1 commit intomasterfrom
bug/verbose

Conversation

@JoelLefkowitz
Copy link
Collaborator

In #106 @fallemand pointed out that the verbose flag was not working. Passing verbose: false explicitly would still be interpreted as true.

The verbose flag was passed as an environment variable and was received as a string which are all considered true in a boolean context:

verbose = ENV.fetch('VERBOSE', nil)

Instead we can consider 'true' to be true only:

config.verbose = verbose == 'true'

@JoelLefkowitz JoelLefkowitz merged commit 34c3887 into master Mar 23, 2025
9 checks passed
@JoelLefkowitz JoelLefkowitz deleted the bug/verbose branch March 23, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments