Symfony 4 support by bodorszilard · Pull Request #276 · lexik/LexikFormFilterBundle

bodorszilard · 2017-11-18T09:25:13Z

#SymfonyConHackday2017

bodorszilard · 2017-11-18T12:30:04Z

the unit tests need to be fixed (it's not related to this pr)

garak · 2017-12-03T17:32:36Z

.travis.yml

 matrix:
+    exclude:
+        - php: 5.6
+          env: DEPENDENCIES='beta' SYMFONY_VERSION='4.0.*' STABLE=beta


You can remove beta, Symfony 4 is stable now

@garak DONE

garak · 2017-12-04T13:37:27Z

I'm afraid this won't work until you add explicit visibility of services

gilles-g · 2017-12-13T08:31:18Z

@garak You can see tests are green on SF3.2 and PHP 7.1, but not with 3.3. And not with PHP 7.0
https://travis-ci.org/lexik/LexikFormFilterBundle/builds/272870684

I'm trying to search why we have these errors, but right now, I don't know.. 🤔

But the tests were already broken on previous commits..

garak · 2017-12-13T08:57:23Z

I see all tests failing. But, again, you need to fix that service visibility. Otherwise, even if you fix tests, Symfony 4 won't work

gilles-g · 2017-12-13T09:44:35Z

Yes the service id lexik_form_filter.query_builder_updater needs to be public and @bodorszilard can update his PR with this fix.

…blic

garak · 2017-12-13T13:33:23Z

I'm afraid you need to make the listener public, too

garak · 2017-12-13T14:14:38Z

Tests/Event/Listenener/PrepareListenerTest.php

+use PHPUnit\Framework\TestCase;

-class PrepareListenerTest extends \PHPUnit_Framework_TestCase
+class PrepareListenerTest extends TestCase


If you want to switch to newer phpunit version, you must be sure to avoid deprecated functions. E.g., $this->getMock() has been removed

garak · 2017-12-27T10:17:50Z

Any news on this PR?

FriTOol · 2018-01-11T11:41:40Z

Any news?

garak · 2018-01-11T13:35:21Z

Tests/Event/Listenener/PrepareListenerTest.php

        $myPlatform = $this->getMockBuilder('Doctrine\DBAL\Platforms\MySqlPlatform')->getMock();

-        $connection    = $this->getMock(
+        $connection    = $this->getMockClass(


maybe getMockBuilder()? And then getMock() on the result.

garak · 2018-01-11T14:37:17Z

Tests/Event/Listenener/PrepareListenerTest.php

-            '',
-            false
-        );
+        $connection    = $this->getMockBuilder('Doctrine\DBAL\Connection')->getMock();


You also need disableOriginalConstructor() here

flaksp · 2018-02-05T06:51:07Z

Any news?

Alex17000 · 2018-02-13T08:22:10Z

Any news? :)

garak · 2018-02-13T08:32:34Z

Still waiting for tests to pass. Until @bodorszilard doesn't make proper changes, I'm afraid that this cannot be merged

gilles-g · 2018-02-13T19:36:11Z

I have tried to fix some tests, but some tests failed and I don't know why and I'm not a specialist of DateRange with different Timezone 😜

Lexik\Bundle\FormFilterBundle\Tests\Filter\Doctrine\DBALQueryBuilderUpdaterTest::testDateRangeWithTimezone
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'SELECT i FROM item i WHERE (i.startAt <= '2015-10-20 23:59:59') AND (i.startAt >= '2015-10-20 00:00:00')'
+'SELECT i FROM item i WHERE (i.startAt <= '2015-10-20 20:59:59') AND (i.startAt >= '2015-10-19 21:00:00')'

cbeyer · 2018-02-16T11:14:35Z

I'm also waiting :)

odinsey · 2018-03-08T08:31:46Z

Any news ? Can't use this bundle in sf3.4 without forking it, just because a service isn't public.
Please Wake Up Lexik Agency

brunonic · 2018-03-09T08:04:24Z

Someone ?

# Conflicts: # Tests/Event/Listenener/PrepareListenerTest.php # composer.json

gilles-g · 2018-03-12T07:43:38Z

@garak What did you think? We can merge PR maybe

garak · 2018-03-12T08:20:06Z

@Spike31 it' OK for me

gilles-g · 2018-03-12T10:14:43Z

Thanks for all your help @bodorszilard and the others of course :)

bodorszilard added 6 commits November 18, 2017 11:24

Symfony 4 support

4f15cfe

#SymfonyConHackday2017

Symfony 4 support

3c00560

#SymfonyConHackday2017

Symfony 4 support

282351e

#SymfonyConHackday2017

Symfony 4 support

6c77bad

#SymfonyConHackday2017

Symfony 4 support (fix phpunit)

945d541

#SymfonyConHackday2017

Symfony 4 support (fix phpunit)

86a11d3

#SymfonyConHackday2017

garak reviewed Dec 3, 2017

View reviewed changes

remove beta

53a0b46

the service id lexik_form_filter.query_builder_updater needs to be pu…

3059d2c

…blic

the listener needs to be public

b0a7a07

garak reviewed Dec 13, 2017

View reviewed changes

garak mentioned this pull request Dec 27, 2017

Deprecation Warning in Symfony 3.3 #268

Closed

remove not existing getMock method

baabede

garak reviewed Jan 11, 2018

View reviewed changes

remove not existing getMock method

05aa157

garak reviewed Jan 11, 2018

View reviewed changes

qtsd mentioned this pull request Feb 22, 2018

Fix tests #283

Merged

fix mock constructor issue

447707f

bodorszilard added 7 commits March 9, 2018 10:36

Merge remote-tracking branch 'upstream/master' into symfony-4-support

45c9111

# Conflicts: # Tests/Event/Listenener/PrepareListenerTest.php # composer.json

fix mock constructor issue

f86bfd0

fix mock constructor issue

aa3cc79

fix mock constructor issue

dde920a

fix travis memory limit issue

4f4a533

fix travis memory limit issue

7e14e8f

fix travis memory limit issue

6f6e411

gilles-g merged commit e248745 into lexik:master Mar 12, 2018

Conversation

bodorszilard commented Nov 18, 2017

Uh oh!

bodorszilard commented Nov 18, 2017

Uh oh!

garak Dec 3, 2017

Choose a reason for hiding this comment

Uh oh!

bodorszilard Dec 4, 2017

Choose a reason for hiding this comment

Uh oh!

garak commented Dec 4, 2017

Uh oh!

gilles-g commented Dec 13, 2017

Uh oh!

garak commented Dec 13, 2017

Uh oh!

gilles-g commented Dec 13, 2017

Uh oh!

garak commented Dec 13, 2017

Uh oh!

garak Dec 13, 2017

Choose a reason for hiding this comment

Uh oh!

garak commented Dec 27, 2017

Uh oh!

FriTOol commented Jan 11, 2018

Uh oh!

garak Jan 11, 2018

Choose a reason for hiding this comment

Uh oh!

garak Jan 11, 2018

Choose a reason for hiding this comment

Uh oh!

flaksp commented Feb 5, 2018

Uh oh!

Alex17000 commented Feb 13, 2018

Uh oh!

garak commented Feb 13, 2018

Uh oh!

gilles-g commented Feb 13, 2018

Uh oh!

cbeyer commented Feb 16, 2018

Uh oh!

odinsey commented Mar 8, 2018

Uh oh!

brunonic commented Mar 9, 2018

Uh oh!

gilles-g commented Mar 12, 2018

Uh oh!

garak commented Mar 12, 2018

Uh oh!

gilles-g commented Mar 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

gilles-g commented Mar 12, 2018 •

edited

Loading