Convert StringOrList helper functions to methods

[coderabbitai]

Problem

Helper functions in the ir module for converting StringOrList values (map_string_or_list, to_paths, to_string_vec, extract_single) are scattered and create repetition.

Proposed Solution

Convert these helper functions into methods on the StringOrList type to:

• Reduce repetition
• Centralise behaviour
• Improve encapsulation

Context

• Identified during code review in PR Clean workflow cache before build #69
• Comment: Clean workflow cache before build #69 (comment)
• Issue: Convert StringOrList helper functions to methods #73

[leynos]

@coderabbitai looking at the codebase, is this issue still relevant? If the issue has been fixed in the code, does the documentation reflect this?

If it is still relevant, please provide an assessment of the issue criticality (critical, high, medium or low), based on risk of the issue impacting the user and the anticipated blast radius.

Once a decision has been made, apply the appropriate label.

If the issue is documentation ONLY (i.e., no code changes needed), apply the documentation label in addition to the appropriate criticality label.

Please also provide an impact of the required changes.

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

@leynos The issue is still relevant and has not been resolved.

Current State Analysis

The codebase still contains:

• StringOrList enum with String and Vec<String> variants in src/ir.rs
• Standalone helper functions: map_string_or_list, to_paths, to_string_vec, extract_single
• No methods implemented on the StringOrList type itself

The refactoring described in the issue has not been completed.

Criticality Assessment: Low

Risk Assessment:

• User Impact: None - this is purely an internal code organization issue
• Blast Radius: Low - changes would be contained to the ir module and its usage
• Developer Experience: Medium positive impact - would improve code maintainability

Impact of Required Changes

Code Changes Needed:

1. Add impl block for StringOrList with new methods
2. Convert 4 standalone functions to methods
3. Update all call sites throughout the codebase
4. Remove the now-redundant standalone functions

Benefits:

• Reduced code repetition
• Better encapsulation and discoverability
• More idiomatic Rust code (methods on types vs. scattered functions)
• Centralised behaviour for StringOrList operations

Estimated Effort: Small to medium - straightforward refactoring with good test coverage needed to ensure no regressions.

I've applied the low criticality label to the issue.

  (\   /)
 ( ._. )
o_("_")("_")  *thinking about code organization*

---

🏁 Script executed:

#!/bin/bash
# First, let's find the StringOrList type definition
echo "=== Searching for StringOrList type definition ==="
rg -n "struct StringOrList|enum StringOrList|type StringOrList" --type rust

echo -e "\n=== Searching for StringOrList usage ==="
rg -n "StringOrList" --type rust -C2

echo -e "\n=== Searching for the mentioned helper functions ==="
echo "Looking for map_string_or_list..."
rg -n "map_string_or_list" --type rust -C2

echo -e "\nLooking for to_paths..."
rg -n "fn to_paths|to_paths\(" --type rust -C2

echo -e "\nLooking for to_string_vec..."
rg -n "fn to_string_vec|to_string_vec\(" --type rust -C2

echo -e "\nLooking for extract_single..."
rg -n "fn extract_single|extract_single\(" --type rust -C2

Length of output: 15734

---

🏁 Script executed:

#!/bin/bash
# Let's also check if there are any impl blocks for StringOrList to see current methods
echo "=== Checking for StringOrList impl blocks ==="
rg -n -A10 "impl.*StringOrList" --type rust

# Check the specific file mentioned in the issue (ir module)
echo -e "\n=== Examining the ir.rs file structure ==="
fd "ir.rs" --exec cat {}

Length of output: 13370

---

🏁 Script executed:

#!/bin/bash
# Apply the appropriate label to the issue
gh issue edit 73 --add-label "low"

Length of output: 78

---

@leynos The issue is still relevant and has not been resolved.

Current State Analysis

The codebase still contains exactly what the issue describes:

• StringOrList enum defined in src/ast.rs with Empty, String, and List variants
• Four standalone helper functions in src/ir.rs:
  • map_string_or_list - generic mapping function
  • to_paths - converts to Vec<PathBuf>
  • to_string_vec - converts to Vec<String>
  • extract_single - extracts single value if possible
• No impl block exists for StringOrList - it has no methods

The refactoring described in the issue has not been completed.

Criticality Assessment: Low

Risk Assessment:

• User Impact: None - purely internal code organization
• Blast Radius: Low - changes contained to ir module and call sites
• Developer Experience: Medium positive impact - better API discoverability

Impact of Required Changes

Code Changes Needed:

1. Add impl StringOrList block with new methods:

   • map<T, F>(&self, f: F) -> Vec<T>
   • to_paths(&self) -> Vec<PathBuf>
   • to_string_vec(&self) -> Vec<String>
   • extract_single(&self) -> Option<&str>

2. Update call sites in src/ir.rs (lines 149, 160, 163, 222, 226, 242, 244)

3. Remove standalone helper functions

Benefits:

• Centralised behaviour on the type itself
• More idiomatic Rust (methods vs. free functions)
• Improved code discoverability
• Reduced function scatter

Estimated Effort: Small - straightforward refactoring with existing test coverage ensuring no regressions.

I've applied the low criticality label to the issue.

  (\   /)
 ( ._. )
o_("_")("_")  *pondering code organization improvements*