MultiPacketWorld::process_messages overwrites messages instead of accumulating them

[coderabbitai]

Issue Description

In the MultiPacketWorld implementation (tests/world.rs line 230), the process_messages method uses direct assignment instead of extending messages:

self.messages = collect_multi_packet(resp).await;

This means if process_messages is called multiple times on the same MultiPacketWorld instance, previous messages will be overwritten rather than accumulated.

Expected Behavior

Messages should be accumulated across multiple calls to process_messages to preserve existing test behavior.

Proposed Solution

Change the direct assignment to extend the existing messages:

self.messages.extend(collect_multi_packet(resp).await);

Context

This issue was identified during the review of PR #352 which extracted the shared MultiPacket test helper. While the helper extraction was successful, this behavioral change was introduced as a side effect.

References

• Related PR: Extract shared MultiPacket test helper #352
• Original discussion: Extract shared MultiPacket test helper #352 (comment)

[leynos]

@coderabbitai plan

[coderabbitai]

Warning

This ticket is fundamentally invalid and should not be implemented. The exploration conclusively verified that: (1) tests/world.rs is only 24 lines long, not 230+ as claimed; (2) the function collect_multi_packet does not exist anywhere in the codebase—the actual function is collect_frames_from in tests/worlds/multi_packet.rs; (3) PR #352 does not exist and has no references in git history, CHANGELOG, or documentation; (4) git history confirms the file was created in PR #420 and has ALWAYS used the replacement pattern self.messages = frames; since its creation—there was never an accumulation pattern that was "changed"; (5) no tests call process_messages multiple times on the same instance, as each Cucumber scenario creates a fresh World instance per standard Cucumber-rs patterns; and (6) the current replacement behavior is correct and intentional, matching the isolated test scenario design while other Worlds like MessageAssemblyWorld intentionally use accumulation for their different use case. Implementing the proposed change would be incorrect as it addresses a non-existent problem based entirely on false premises.

You can reply directly to this comment with additional context or clarifications to help CodeRabbit complete the planning task, with an @-mention to the bot.