Export the enums from the main entrypoint#64
Closed
illright wants to merge 2 commits intolezer-parser:mainfrom
illright:main
Closed
Export the enums from the main entrypoint#64illright wants to merge 2 commits intolezer-parser:mainfrom illright:main
illright wants to merge 2 commits intolezer-parser:mainfrom
illright:main
Conversation
Collaborator
|
These enums aren't public. What are you doing that needs access to them? |
Author
|
The |
Collaborator
|
Yes, and its build system can handle that. |
Author
|
Wouldn't it be better if any build system could handle that? Are there any downsides to the solution I proposed? |
Collaborator
|
Yes. It makes these enums non-const, changes things around, without addressing anything I actually consider a problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the enums were exported from an additional file,
./dist/constants, which was a problem for some bundlers like esbuild because the./dist/constantsentrypoint isn't declared in the package.json. After reexporting them from the main entrypoint I found out that it still didn't work right because esbuild can't inline const enums across packages (and frankly, I wouldn't expect it to). Thus, I've changed enums to regular ones and exported them from the index, and now the generator package builds correctly with my PR for Unplugin