Do not create base device config#150
Merged
eriknordmark merged 2 commits intolf-edge:masterfrom May 3, 2026
Merged
Conversation
milan-zededa
requested review from
eriknordmark,
europaul,
rene and
uncleDecart
milan-zededa
force-pushed
the
remove-base-config
branch
2 times, most recently
from
5cc9479 to
fc8c06b
Compare
Previously, Adam automatically created a minimal "base" config for every newly registered device. This caused two problems: 1. It made it impossible to test the scenario where the controller has no config for a device yet, which is a legitimate scenario that test frameworks need to exercise. 2. Devices can be provisioned with a bootstrap config baked in, which is necessary when the default network setup (DHCP on all Ethernet interfaces) does not provide controller connectivity -- for example when the network uses static IP addresses, VLANs, or a HTTP proxy for management traffic. If the test framework was too slow to submit the initial config, the device would fetch the auto-generated base config first, effectively overwriting the bootstrap config (and breaking connectivity for a while, until network config fallback kicks in). This forced the test framework to race against the first device config poll, an inherently fragile arrangement. With this change, GetConfig returns NotFoundError when no config has been submitted yet. The API handlers propagate this as an HTTP 404, allowing the device to retry. GetDeviceOptions and GetGlobalOptions likewise return NotFoundError instead of auto-creating defaults; their callers treat not-found as "use zero-value defaults". Signed-off-by: Milan Lenco <milan@zededa.com>
milan-zededa
force-pushed
the
remove-base-config
branch
from
fc8c06b to
bb61c16
Compare
Redis tests were silently skipped because no Redis instance was available. Add a Redis 7 service container with a health check so the full Redis driver test suite runs on every PR. Signed-off-by: Milan Lenco <milan@zededa.com>
milan-zededa
force-pushed
the
remove-base-config
branch
from
b3dc369 to
07e14ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, Adam automatically created a minimal "base" config for every newly registered device. This caused two problems:
It made it impossible to test the scenario where the controller has no config for a device yet, which is a legitimate scenario that test frameworks need to exercise.
Devices can be provisioned with a bootstrap config baked in, which is necessary when the default network setup (DHCP on all Ethernet interfaces) does not provide controller connectivity -- for example when the network uses static IP addresses, VLANs, or a HTTP proxy for management traffic. If the test framework was too slow to submit the initial config, the device would fetch the auto-generated base config first, effectively overwriting the bootstrap config (and breaking connectivity for a while, until network config fallback kicks in). This forced the test framework to race against the first device config poll, an inherently fragile arrangement.
With this change,
GetConfigreturnsNotFoundErrorwhen no config has been submitted yet. The API handlers propagate this as an HTTP 404, allowing the device to retry.GetDeviceOptionsandGetGlobalOptionslikewise returnNotFoundErrorinstead of auto-creating defaults; their callers treat not-found as "use zero-value defaults".I have also enhanced the CI workflow to include running a Redis container. Previously, all Redis tests were silently skipped because no Redis instance was available.