Add hw inventory capability

[europaul]

Signal to the controller that it should expect a hardware inventory report from the device.

[christoph-zededa]

I am unsure if it should be OptionalCapability or APICapability...

I understand APICapability as that from now on every EVE version is supporting this capability, while OptionalCapability is used for capabilities that not necessarily is supported in all EVE versions from now on.
As the hw inventory is supported by all future EVE versions, I would guess it should be an APICapability?

Or should be just abandon APICapability because of it's shortcomings?

[eriknordmark]

The OptionalCapabilities makes more sense if only a subset of EVE nodes (for any given version) will support it, or if we are certain we will remove it in future versions.

But otherwise the more compact APICapability makes more sense.

[europaul]

This is how I understood those fields from reading the docs:

• eve-api/proto/info/info.proto

  Lines 698 to 703 in b9d7403

  	// Capabilities indicates features in the EdgeDevConfig where there is
  	// no easy way to otherwise determine whether or not they are parsed and
  	// supported by EVE-OS
  	// A larger number indicates all lower numbers are also supported thus
  	// this works similar to a version field for the EdgeDevConfig support.
  	enum APICapability {

  - APICapability describes some feature of EVE that can be turned on / configured through EdgeDevConfig. So the controller needs to know that if it turns it on in EdgeDevConfig it will indeed have effect on EVE

• eve-api/proto/info/info.proto

  Lines 689 to 691 in b9d7403

  	// OptionalCapabilities indicates any additional capabilities device wants
  	// to publish to controller. For example Kubevirt hypervisor is not supported by
  	// all eve flavors.

  - OptionalCapabilities is something that's not available in every EVE version (you're right) but also something that EVE wants to tell to the controller about itself - not related to EdgeDevConfig - more like a passive feature, like what hypervisor it uses. That sounds to me more like "I will send HW inventory, you don't need to do anything, just be aware".

[europaul]

@eriknordmark what do you think?

[eriknordmark]

You're correct that this doesn't affect what needs to be configured so let's not put it in api capability. Just check with @zed-rishabh that he doesn't see issues with the controller accessing this field to decide how to proceed.