Skip to content

Fix an issue in Edgeview not getting App interface IP address#4374

Closed
naiming-zededa wants to merge 1 commit intolf-edge:13.4-stablefrom
naiming-zededa:naiming-backport-4352
Closed

Fix an issue in Edgeview not getting App interface IP address#4374
naiming-zededa wants to merge 1 commit intolf-edge:13.4-stablefrom
naiming-zededa:naiming-backport-4352

Conversation

@naiming-zededa
Copy link
Copy Markdown
Contributor

- backport #lf-edge#4352
- due to the change of multiple port in zedrouter, the
  AppNetAdapterList.AllocatedIPv4Addr was changed to AssignedAddresses,
  do the same change

Signed-off-by: Naiming Shen <naiming@zededa.com>
Copy link
Copy Markdown
Member

@OhmSpectator OhmSpectator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a 1-to-1 cherry-pick of the original commit

Copy link
Copy Markdown
Member

@OhmSpectator OhmSpectator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naiming-zededa, could you please cherry-pic commit like this?

git cherry-pick -x a54bfb3c0c119bc62e65b94c7a4deccc64c45a63

We don't need GH PR number in the commit message. And it's better to stick to the original one.

@OhmSpectator OhmSpectator self-requested a review October 17, 2024 19:05
@naiming-zededa
Copy link
Copy Markdown
Contributor Author

@naiming-zededa, could you please cherry-pic commit like this?

git cherry-pick -x a54bfb3c0c119bc62e65b94c7a4deccc64c45a63

We don't need GH PR number in the commit message. And it's better to stick to the original one.

ok, let me retry.

@OhmSpectator
Copy link
Copy Markdown
Member

ok, let me retry.

retry = retry - 1

(just kidding)

@naiming-zededa
Copy link
Copy Markdown
Contributor Author

ok, let me retry.

retry = retry - 1

(just kidding)

Haha, but the above commands of hash does not seem to bring in the vendor files...

@OhmSpectator
Copy link
Copy Markdown
Member

Haha, but the above commands of hash does not seem to bring in the vendor files...

Sure, for the vendor file, you can try to cherry-pick 3769a42 or just rerun the command and create a new commit with the result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants