Skip to content

Use Yetus container from lfedge/eve-yetus#5397

Merged
rene merged 1 commit intolf-edge:masterfrom
rene:fix-yetus-local
Mar 4, 2026
Merged

Use Yetus container from lfedge/eve-yetus#5397
rene merged 1 commit intolf-edge:masterfrom
rene:fix-yetus-local

Conversation

@rene
Copy link
Copy Markdown
Contributor

@rene rene commented Nov 12, 2025

Description

Start to use our Yetus container, which has dependencies already installed (e.g. ZFS lib, etc).

How to test and validate this PR

Run the following commands and check if everything works:

  1. make yetus
  2. make mini-yetus

Changelog notes

No user-facing changes.

PR Backports

No need to backport.

Checklist

  • I've provided a proper description
  • I've added the proper documentation
  • I've tested my PR on amd64 device
  • I've tested my PR on arm64 device
  • I've written the test verification instructions
  • I've set the proper labels to this PR
  • I've checked the boxes above, or I've provided a good reason why I didn't
    check them.

@rene rene requested a review from deitch as a code owner November 12, 2025 09:01
@rene rene added the stable Should be backported to stable release(s) label Nov 12, 2025
@rene rene requested a review from eriknordmark as a code owner November 12, 2025 09:01
@github-actions github-actions Bot requested a review from jsfakian November 12, 2025 09:01
Copy link
Copy Markdown
Contributor

@rucoder rucoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rene please give a URL to source code repo for the container in the commit and PR description. i tried github.com/lf-edge/eve-yetus but it doesn't exist

@rene
Copy link
Copy Markdown
Contributor Author

rene commented Nov 12, 2025

@rucoder , we had a discuss before about create a lf-edge/eve-yetus project and one of the points raised was that this would be a new project to maintain, build, etc, my plan is to provide the sources here in eve repo and create a GH action to build the eve-yetus image on demand (since this is something we won't upgrade very often).... I don't mind to do that in this PR, but this will take time, or we can merge this one and leave a bit more just with the image....

@rucoder
Copy link
Copy Markdown
Contributor

rucoder commented Nov 12, 2025

@rucoder , we had a discuss before about create a lf-edge/eve-yetus project and one of the points raised was that this would be a new project to maintain, build, etc, my plan is to provide the sources here in eve repo and create a GH action to build the eve-yetus image on demand (since this is something we won't upgrade very often).... I don't mind to do that in this PR, but this will take time, or we can merge this one and leave a bit more just with the image....

That makes sense. But please add a disclaimer then.

@rene
Copy link
Copy Markdown
Contributor Author

rene commented Nov 12, 2025

@rucoder , here it is: #5399

@rucoder rucoder self-requested a review November 12, 2025 20:47
Comment thread Makefile Outdated
@rene rene marked this pull request as draft November 20, 2025 13:06
@rene rene closed this Mar 3, 2026
@rene rene deleted the fix-yetus-local branch March 3, 2026 09:20
@rene rene restored the fix-yetus-local branch March 3, 2026 22:24
@rene rene reopened this Mar 4, 2026
Start to use our Yetus container, which has dependencies already
installed (e.g. ZFS lib, etc).

Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
@rene rene force-pushed the fix-yetus-local branch from dc1ba2a to 7db7e25 Compare March 4, 2026 12:32
@rene rene marked this pull request as ready for review March 4, 2026 12:38
@rene
Copy link
Copy Markdown
Contributor Author

rene commented Mar 4, 2026

@eriknordmark , @rucoder this PR is ready for review.

  1. A new GH workflow was introduced to build Yetus image on demand (maintainers can trigger it manually)
  2. As suggested here, the version now has the format: <yetus version>-eve-<eve yetus release>. For example: 0.15.1-eve-1, 0.15.1-eve-2, etc
  3. Images are available at: https://hub.docker.com/r/lfedge/eve-yetus/tags
  4. This PR make the changes to use our images on Makefile and mini-yetus script.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 29.49%. Comparing base (2281599) to head (7db7e25).
⚠️ Report is 322 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5397      +/-   ##
==========================================
+ Coverage   19.52%   29.49%   +9.96%     
==========================================
  Files          19       18       -1     
  Lines        3021     2417     -604     
==========================================
+ Hits          590      713     +123     
+ Misses       2310     1552     -758     
- Partials      121      152      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rene rene dismissed rucoder’s stale review March 4, 2026 14:28

Approved by Erik, let's trigger tests

@rene rene merged commit 1d8ba05 into lf-edge:master Mar 4, 2026
36 checks passed
@rene rene deleted the fix-yetus-local branch April 2, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stable Should be backported to stable release(s)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants