pkg/pillar: skip TestPciLongExists in unit tests#5583
Merged
eriknordmark merged 1 commit intolf-edge:masterfrom Jan 31, 2026
Merged
pkg/pillar: skip TestPciLongExists in unit tests#5583eriknordmark merged 1 commit intolf-edge:masterfrom
eriknordmark merged 1 commit intolf-edge:masterfrom
Conversation
The TestPciLongExists unit test relies on the presence of specific PCI devices (e.g., 0000:00:00.0) on the host system running the tests. This causes failures in CI environments or on non-x86 architectures where such devices may not exist or be accessible. This change skips the test to avoid false negatives. Signed-off-by: Shahriyar Jalayeri <shahriyar@posteo.de>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5583 +/- ##
==========================================
+ Coverage 19.52% 28.32% +8.79%
==========================================
Files 19 18 -1
Lines 3021 2256 -765
==========================================
+ Hits 590 639 +49
+ Misses 2310 1475 -835
- Partials 121 142 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
@shjala , please, provide the backport of this PR to 16.0-stable. Go-tests are broken on this branch. |
This was referenced Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The TestPciLongExists unit test relies on the presence of specific PCI devices (e.g., 0000:00:00.0) on the host system running the tests. This causes failures in CI environments or on non-x86 architectures where such devices may not exist or be accessible.
This change skips the test to avoid false negatives.
PR dependencies
None
How to test and validate this PR
N/A/
Changelog notes
N/A.
PR Backports
For all current LTS branches, please state explicitly if this PR should be
backported or not. This section is used by our scripts to track the backports,
so, please, do not omit it.
Here is the list of current LTS branches (it should be always up to date):
For example, if this PR fixes a bug in a feature that was introduced in 14.5,
you can write:
Also, to the PRs that should be backported into any stable branch, please
add a label
stable.Checklist
For backport PRs (remove it if it's not a backport):
And the last but not least:
check them.
Please, check the boxes above after submitting the PR in interactive mode.