Skip to content

pkg/pillar: skip TestPciLongExists in unit tests#5583

Merged
eriknordmark merged 1 commit intolf-edge:masterfrom
shjala:skip.TestPciLong
Jan 31, 2026
Merged

pkg/pillar: skip TestPciLongExists in unit tests#5583
eriknordmark merged 1 commit intolf-edge:masterfrom
shjala:skip.TestPciLong

Conversation

@shjala
Copy link
Copy Markdown
Member

@shjala shjala commented Jan 29, 2026

Description

The TestPciLongExists unit test relies on the presence of specific PCI devices (e.g., 0000:00:00.0) on the host system running the tests. This causes failures in CI environments or on non-x86 architectures where such devices may not exist or be accessible.

This change skips the test to avoid false negatives.

PR dependencies

None

How to test and validate this PR

N/A/

Changelog notes

N/A.

PR Backports

For all current LTS branches, please state explicitly if this PR should be
backported or not. This section is used by our scripts to track the backports,
so, please, do not omit it.

Here is the list of current LTS branches (it should be always up to date):

  • 16.0-stable
  • 14.5-stable
  • 13.4-stable

For example, if this PR fixes a bug in a feature that was introduced in 14.5,
you can write:

- 16.0-stable: To be backported.
- 14.5-stable: No, as the feature is not available there.
- 13.4-stable: No, as the feature is not available there.

Also, to the PRs that should be backported into any stable branch, please
add a label stable.

Checklist

  • I've provided a proper description
  • I've added the proper documentation
  • I've tested my PR on amd64 device
  • I've tested my PR on arm64 device
  • I've written the test verification instructions
  • I've set the proper labels to this PR

For backport PRs (remove it if it's not a backport):

  • I've added a reference link to the original PR
  • PR's title follows the template

And the last but not least:

  • I've checked the boxes above, or I've provided a good reason why I didn't
    check them.

Please, check the boxes above after submitting the PR in interactive mode.

The TestPciLongExists unit test relies on the presence of specific
PCI devices (e.g., 0000:00:00.0) on the host system running the tests.
This causes failures in CI environments or on non-x86 architectures
where such devices may not exist or be accessible.

This change skips the test to avoid false negatives.

Signed-off-by: Shahriyar Jalayeri <shahriyar@posteo.de>
@shjala shjala requested a review from eriknordmark as a code owner January 29, 2026 14:58
Copy link
Copy Markdown
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 28.32%. Comparing base (2281599) to head (9b7cc85).
⚠️ Report is 256 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5583      +/-   ##
==========================================
+ Coverage   19.52%   28.32%   +8.79%     
==========================================
  Files          19       18       -1     
  Lines        3021     2256     -765     
==========================================
+ Hits          590      639      +49     
+ Misses       2310     1475     -835     
- Partials      121      142      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eriknordmark eriknordmark merged commit 9d4d5ba into lf-edge:master Jan 31, 2026
47 of 50 checks passed
@rene
Copy link
Copy Markdown
Contributor

rene commented Mar 18, 2026

@shjala , please, provide the backport of this PR to 16.0-stable. Go-tests are broken on this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants