Makefile: add eden target for running Eden tests#5587
Makefile: add eden target for running Eden tests#5587eriknordmark merged 1 commit intolf-edge:masterfrom
Conversation
shjala
force-pushed
the
makefile.eden
branch
2 times, most recently
from
b744bd0 to
1275bb2
Compare
| (cd "$EDEN_DIR" && ./eden stop 2>/dev/null) || true | ||
| fi | ||
| docker rm -f eden_adam eden_redis 2>/dev/null || true | ||
| rm -rf ~/.eden || true |
There was a problem hiding this comment.
Couldn't we just use eden clean here? Do we really need to remove ~/.eden? I think this is too invasive for the user... Personally I run eden from time to time locally, in this way the Makefile might destroy a setup created by the user.... I understand we might have clashes anyways, but I would avoid to remove a file from user's home....
There was a problem hiding this comment.
sure, this is just left over from my struggle to remove all the traces of eden while testing things.
I will change it to eden clean, I think it also makes sense to add and use a non-default config, then I can delete that too.
There was a problem hiding this comment.
made some changes, please review again.
|
@shjala thanks a lot for this PR, this is really useful.... |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5587 +/- ##
==========================================
+ Coverage 19.52% 28.32% +8.79%
==========================================
Files 19 18 -1
Lines 3021 2256 -765
==========================================
+ Hits 590 639 +49
+ Misses 2310 1475 -835
- Partials 121 142 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eriknordmark
left a comment
eriknordmark
left a comment
There was a problem hiding this comment.
Thanks for doing this!
Should we mention this new target e.g., in BUILD.md?
@eriknordmark added. |
This commit introduces a new `eden` target in the Makefile to facilitate running Eden tests directly from the build system. Signed-off-by: Shahriyar Jalayeri <shahriyar@posteo.de>
shjala
force-pushed
the
makefile.eden
branch
3 times, most recently
from
8f20a1e to
6c45e95
Compare
4 participants
Description
This PR introduces a new make eden target to make running Eden tests against locally built EVE easier.
From docs:
To streamline the testing process using Eden, a convenience target
edenis available. This target sets up the environment and executes the Eden test suite against the built EVE image.You can customize the execution with standard Makefile variables (which configure the EVE image properties expected by Eden):
HV: Hypervisor flavor (e.g.,kvm)ZARCH: Architecture (e.g.,amd64)TPM=y: Enable TPM simulation (defaults to disabled)NOACCEL=1: Disable hardware acceleration (defaults to enabled)To control which tests are run, you can pass environment variables to the Eden runner script:
EDEN_TAG: Tag of Eden to use (default: 1.0.13)TEST_SMOKE=y: Run smoke tests,TEST_NET=yfor running networking tests (checkTEST_XXXfor more targets).TEST_ALL=y: Run all testsSETUP_ONLY=y: Only perform setup (onboard EVE) and exit without running testsExample running only smoke tests with TPM enabled:
Logs are available at
dist/<arch>/current/eden/runlogs. Since all Eden artifacts are stored within thedistdirectory, runningmake cleanwill also clean up all Eden-related resources and leftovers.PR dependencies
N/A
How to test and validate this PR
make edenPR Backports
N/A
Checklist
For backport PRs (remove it if it's not a backport):
And the last but not least:
check them.
Please, check the boxes above after submitting the PR in interactive mode.