Makefile: Fail for unsupported hypervisor#5592
Merged
eriknordmark merged 1 commit intolf-edge:masterfrom Feb 7, 2026
Merged
Conversation
Currently Makefile accepts any value for HV. This commit introduces a check to fail in case a unsupported hypervisor is passed through HV variable. Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
christoph-zededa
approved these changes
Feb 4, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5592 +/- ##
==========================================
+ Coverage 19.52% 29.49% +9.96%
==========================================
Files 19 18 -1
Lines 3021 2417 -604
==========================================
+ Hits 590 713 +123
+ Misses 2310 1552 -758
- Partials 121 152 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
milan-zededa
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently Makefile accepts any value for HV. This PR introduces a check to fail in case a unsupported hypervisor is passed through HV variable.
How to test and validate this PR
Try to build with non-valid
HVvalues. It should fail:Of course it should build for valid HV values:
acrn,kvm,k,miniandxen.Changelog notes
No user-facing changes.
PR Backports
No backports are needed for this PR. This is an improvement.
Checklist
check them.