eve-k: set longhorn node-down-pod-deletion-policy

[andrewd-zededa]

Description

For app failover performance optimization.
Move this and upgrade-checker into common config
yaml instead of patch command.

PR dependencies

None

How to test and validate this PR

• deploy HV=k eve nodes
• onboard to supporting cluster as EdgeNodeClusterConfig
• verify kubectl -n longhorn-system get settings.longhorn.io/node-down-deletion-policy reports delete-both-statefulset-and-deployment-pod

Changelog notes

Optimize app failover speeds

PR Backports

• 16.0-stable: To be backported.
• 14.5-stable: No, as the feature is not available there.
• 13.4-stable: No, as the feature is not available there.

Checklist

• I've provided a proper description
• I've added the proper documentation
• I've tested my PR on amd64 device
• I've tested my PR on arm64 device
• I've written the test verification instructions
• I've set the proper labels to this PR

And the last but not least:

• I've checked the boxes above, or I've provided a good reason why I didn't
  check them.

Please, check the boxes above after submitting the PR in interactive mode.

[naiming-zededa]

LGTM

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 29.49%. Comparing base (2281599) to head (25f7147).
⚠️ Report is 304 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5603      +/-   ##
==========================================
+ Coverage   19.52%   29.49%   +9.96%     
==========================================
  Files          19       18       -1     
  Lines        3021     2417     -604     
==========================================
+ Hits          590      713     +123     
+ Misses       2310     1552     -758     
- Partials      121      152      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[zedi-pramodh]

LGTM

[zedi-pramodh]

Only question I have is since we are copying into manifests directory, does it cause lots of logs messages if longhorn gets deleted in zks environment?

[andrewd-zededa]

Only question I have is since we are copying into manifests directory, does it cause lots of logs messages if longhorn gets deleted in zks environment?

cluster-init.sh line 1387 will remove it for base_mode.

[rene]

@andrewd-zededa , don't forget to go through the checklist and mark the PR as ready for review once you are done...

[andrewd-zededa]

@rene Can you add stable label here, I don't have permissions.

[zedi-pramodh]

LGTM