Fix for code scanning alert no. 75: Clear-text logging of sensitive information

[eriknordmark]

Potential fix for https://github.com/lf-edge/eve/security/code-scanning/75

In general, sensitive values such as API keys should never be logged in clear text. If logging is needed for diagnostics, log only non-sensitive metadata (e.g., that a key exists, its length, or a partially redacted version), or omit the field entirely.

For this specific case, the minimal fix without changing behavior elsewhere is to adjust the fmt.Printf call on line 587 so that it no longer prints data.ApiKey directly. The rest of the line (datastore type, FQDN, path, and cipher flag) can remain. A safe, low-impact approach is to replace the printed key with either a fixed placeholder (e.g., <redacted>) or a derived, non-sensitive summary (e.g., length). Since we must not assume any new helper functions or wider context, the simplest fix is to change the format string and arguments so the key is not passed into Printf at all and instead a constant placeholder is shown.

Concretely, in pkg/edgeview/src/system.go, in the getCipher function around lines 583–588, modify the fmt.Printf used to print datastore details so that it no longer includes data.ApiKey. For example, change:

fmt.Printf("  type: %s, FQDN: %s, ApiKey: %s, path: %s, Is Cipher: %v\n",
    data.DsType, data.Fqdn, data.ApiKey, data.Dpath, data.IsCipher)

to:

fmt.Printf("  type: %s, FQDN: %s, ApiKey: <redacted>, path: %s, Is Cipher: %v\n",
    data.DsType, data.Fqdn, data.Dpath, data.IsCipher)

No new imports or helper methods are required.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

[eriknordmark]

LGTM but @naiming-zededa can you take a look?

[naiming-zededa]

LGTM

[rene]

@eriknordmark , you need to Sign-off the commit so DCO can pass....

[eriknordmark]

@eriknordmark , you need to Sign-off the commit so DCO can pass....

@rene Done.