eve-k: fix node delete if replicas list encounters crd get error#5637
Merged
rene merged 1 commit intolf-edge:masterfrom Mar 8, 2026
Merged
eve-k: fix node delete if replicas list encounters crd get error#5637rene merged 1 commit intolf-edge:masterfrom
rene merged 1 commit intolf-edge:masterfrom
Conversation
github-actions
Bot
requested review from
eriknordmark,
naiming-zededa and
zedi-pramodh
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5637 +/- ##
==========================================
+ Coverage 19.52% 29.49% +9.96%
==========================================
Files 19 18 -1
Lines 3021 2417 -604
==========================================
+ Hits 590 713 +123
+ Misses 2310 1552 -758
- Partials 121 152 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrewd-zededa
force-pushed
the
eve-k-node-delete-defer
branch
from
3226403 to
93e0b42
Compare
andrewd-zededa
changed the title
Fix LonghornReplicaList to be more resilient to failure modes. If the longhorn namespace exists pointing to an intact longhorn install, but the replica crd is missing, return no replicas and no error. This allows drain to be skipped and node delete or cluster delete to continue in a time efficient process. Fix Node Delete to be more resilient, defer node delete to run even in all error cases. Signed-off-by: Andrew Durbin <andrewd@zededa.com>
andrewd-zededa
force-pushed
the
eve-k-node-delete-defer
branch
from
93e0b42 to
2083092
Compare
Contributor
Author
|
rebased, let's see if the spdx issue clears up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix LonghornReplicaList to be more resilient to failure modes. If the longhorn namespace exists pointing to an intact longhorn install but the replica crd is missing, return no replicas and no error. This allows drain to be skipped and node delete or cluster delete to continue in a time efficient process.
Fix Node Delete to be more resilient, defer node delete to run even in all error cases.
PR dependencies
None
How to test and validate this PR
Changelog notes
None
PR Backports
Checklist
And the last but not least:
check them.
Please, check the boxes above after submitting the PR in interactive mode.