Skip to content

pkg/xen-tools: remove unused firmware#5645

Merged
rene merged 2 commits intolf-edge:masterfrom
christoph-zededa:remove_unused_qemu_firmwares
Mar 3, 2026
Merged

pkg/xen-tools: remove unused firmware#5645
rene merged 2 commits intolf-edge:masterfrom
christoph-zededa:remove_unused_qemu_firmwares

Conversation

@christoph-zededa
Copy link
Copy Markdown
Contributor

@christoph-zededa christoph-zededa commented Mar 2, 2026

Description

pkg/xen-tools: remove unused firmware

for:

  • System/390
  • HP Precision Architecutre
  • Riscv 32/64 bit
  • Power PC
  • OpenPower

How to test and validate this PR

Run different edge apps and check that all of them work as before.

Changelog notes

Removing unused firmwares for qemu.

PR Backports

For all current LTS branches, please state explicitly if this PR should be
backported or not. This section is used by our scripts to track the backports,
so, please, do not omit it.

Here is the list of current LTS branches (it should be always up to date):

  • 16.0-stable: no
  • 14.5-stable: no
  • 13.4-stable: no

Checklist

  • I've provided a proper description
  • I've added the proper documentation
  • I've tested my PR on amd64 device
  • I've tested my PR on arm64 device
  • I've written the test verification instructions
  • I've set the proper labels to this PR

And the last but not least:

  • I've checked the boxes above, or I've provided a good reason why I didn't
    check them.

Please, check the boxes above after submitting the PR in interactive mode.

for:
- System/390
- HP Precision Architecutre
- Riscv 32/64 bit
- Power PC
- OpenPower

Signed-off-by: Christoph Ostarek <christoph@zededa.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 29.49%. Comparing base (2281599) to head (3256cdc).
⚠️ Report is 319 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5645      +/-   ##
==========================================
+ Coverage   19.52%   29.49%   +9.96%     
==========================================
  Files          19       18       -1     
  Lines        3021     2417     -604     
==========================================
+ Hits          590      713     +123     
+ Misses       2310     1552     -758     
- Partials      121      152      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes several QEMU firmware blobs from the pkg/xen-tools container image to reduce shipped content for architectures that are not intended to be supported/used.

Changes:

  • Delete OpenPOWER/ppc firmware (skiboot.lid, slof.bin)
  • Delete HPPA firmware (hppa-firmware.img)
  • Delete s390 and RISC-V firmware (s390-netboot.img, opensbi-riscv32/64-...)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pkg/xen-tools/Dockerfile Outdated
@christoph-zededa christoph-zededa marked this pull request as ready for review March 2, 2026 18:33
move cleaning-up of unnecessary files out of building
the scratch image to save time when transferring data
from build image to scratch image

Signed-off-by: Christoph Ostarek <christoph@zededa.com>
Copy link
Copy Markdown
Contributor

@rene rene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rene rene merged commit d2b9f75 into lf-edge:master Mar 3, 2026
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants