github/workflows: Build x86 + arm64 Yetus images at once#5646
Merged
rene merged 1 commit intolf-edge:masterfrom Mar 4, 2026
Merged
github/workflows: Build x86 + arm64 Yetus images at once#5646rene merged 1 commit intolf-edge:masterfrom
rene merged 1 commit intolf-edge:masterfrom
Conversation
Unfortunately the job matrix cannot be used to build Yetus image because the job that finishes last will overwrite the image pushed to dockerhub. Since only x86 runners are used to build this image, there is no need to complicate the handling of manifests. Instead, we can just build and push both images at once. There are no advantages of the current matrix implementation. Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
europaul
approved these changes
Mar 4, 2026
Contributor
europaul
left a comment
europaul
left a comment
There was a problem hiding this comment.
LGTM, but tbh I don't understand why they ended up overwriting each other before - those are different architectures... or is it just a quirk of buildx?
Contributor
Author
Both images have the same TAG, so if we don't treat them properly through fat manifests they will overwrite each other.... I think this is the easiest fix, buildx will handle everything and is going to run build in parallel anyways, so definitely we don't need job matrix here.... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Unfortunately the job matrix cannot be used to build Yetus image because the job that finishes last will overwrite the image pushed to dockerhub. Since only x86 runners are used to build this image, there is no need to complicate the handling of manifests. Instead, we can just build and push both images at once. There are no advantages of the current matrix implementation.
How to test and validate this PR
This PR was tested on my repo: https://github.com/rene/eve/actions/runs/22551285945
Changelog notes
No user-facing changes.
PR Backports
This is a build-on-demand workflow, there is no need to backport.
Checklist
check them.