Skip to content

Fix: the issue of kubevirt feature backwards compatibity#5647

Merged
rene merged 1 commit intolf-edge:masterfrom
naiming-zededa:naiming-kubevirt-feature-patch
Mar 5, 2026
Merged

Fix: the issue of kubevirt feature backwards compatibity#5647
rene merged 1 commit intolf-edge:masterfrom
naiming-zededa:naiming-kubevirt-feature-patch

Conversation

@naiming-zededa
Copy link
Copy Markdown
Contributor

Description

  • the PR kubevirt: Support kubevirt use virtio device #5638 introduced a regression. If the VMI on eve-k is already running, this new EVE image update won't automatically set the new feature item in kubevirt-feature.yaml, which can cause the VMI after update to fail to launch
  • this patch have a migration path to detect if this video feature is not there, apply the patch to that.

PR dependencies

How to test and validate this PR

Changelog notes

Fix: the issue of kubevirt feature backwards compatibity

PR Backports

Checklist

  • I've provided a proper description
  • I've added the proper documentation
  • I've tested my PR on amd64 device
  • I've tested my PR on arm64 device
  • I've written the test verification instructions
  • I've set the proper labels to this PR

For backport PRs (remove it if it's not a backport):

  • I've added a reference link to the original PR
  • PR's title follows the template

And the last but not least:

  • I've checked the boxes above, or I've provided a good reason why I didn't
    check them.

- the PR lf-edge#5638 introduced a regression. If the VMI on eve-k is already
  running, this new EVE image update won't automatically set the new
  feature item in kubevirt-feature.yaml, which can cause the VMI after
  update to fail to launch
- this patch have a migration path to detect if this video feature is
  not there, apply the patch to that.

Signed-off-by: naiming-zededa <naiming@zededa.com>
Copy link
Copy Markdown
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run tests

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 29.49%. Comparing base (2281599) to head (1fbfbd6).
⚠️ Report is 325 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5647      +/-   ##
==========================================
+ Coverage   19.52%   29.49%   +9.96%     
==========================================
  Files          19       18       -1     
  Lines        3021     2417     -604     
==========================================
+ Hits          590      713     +123     
+ Misses       2310     1552     -758     
- Partials      121      152      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rene rene merged commit 105260e into lf-edge:master Mar 5, 2026
50 of 51 checks passed
@naiming-zededa naiming-zededa deleted the naiming-kubevirt-feature-patch branch March 5, 2026 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants