Skip to content

go-tests.yml: remove pull request target#5657

Merged
eriknordmark merged 2 commits intolf-edge:masterfrom
europaul:workflow/remove-pull-request-target
Mar 5, 2026
Merged

go-tests.yml: remove pull request target#5657
eriknordmark merged 2 commits intolf-edge:masterfrom
europaul:workflow/remove-pull-request-target

Conversation

@europaul
Copy link
Copy Markdown
Contributor

@europaul europaul commented Mar 5, 2026

Description

This pull request makes several small but important improvements to the GitHub Actions workflows. The main focus is on fixing conditional expressions for Docker Hub login steps and updating the event trigger for Go tests to improve maintainability.

PR dependencies

None

How to test and validate this PR

Run CI on another branch.

Changelog notes

N/A

PR Backports

- 16.0-stable: To be backported.
- 14.5-stable: To be backported.
- 13.4-stable: To be backported.

Checklist

  • I've provided a proper description
  • I've added the proper documentation
  • I've tested my PR on amd64 device
  • I've tested my PR on arm64 device
  • I've written the test verification instructions
  • I've set the proper labels to this PR

europaul added 2 commits March 5, 2026 18:48
Fixes "Conditional expression contains literal text outside replacement
tokens. This will cause the expression to always evaluate to truthy. Did
you mean to put the entire expression inside ${{ }}?"

Signed-off-by: Paul Gaiduk <paulg@zededa.com>
And change the docker login step.

Signed-off-by: Paul Gaiduk <paulg@zededa.com>
@europaul europaul added the stable Should be backported to stable release(s) label Mar 5, 2026
@europaul europaul requested review from rene and removed request for eriknordmark and yash-zededa March 5, 2026 17:57
@eriknordmark eriknordmark merged commit 95c42e8 into lf-edge:master Mar 5, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stable Should be backported to stable release(s)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants