pkg/pillar: remove unsupported linuxkit build.yml fields#5662
Merged
eriknordmark merged 1 commit intolf-edge:masterfrom Mar 9, 2026
Merged
pkg/pillar: remove unsupported linuxkit build.yml fields#5662eriknordmark merged 1 commit intolf-edge:masterfrom
eriknordmark merged 1 commit intolf-edge:masterfrom
Conversation
Remove security_opt and ports fields from build-dev.yml and build-k-dev.yml. These are Docker Compose-specific fields that have never been valid in linuxkit package build.yml files and were silently ignored by older linuxkit versions. The upcoming linuxkit upgrade introduces strict YAML validation that rejects unknown fields, so these must be removed first. Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5662 +/- ##
==========================================
+ Coverage 19.52% 29.49% +9.96%
==========================================
Files 19 18 -1
Lines 3021 2417 -604
==========================================
+ Hits 590 713 +123
+ Misses 2310 1552 -758
- Partials 121 152 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@rene do you know why CodeCov is 331 commit behind ? |
This was referenced Mar 24, 2026
3 tasks
Contributor
@rucoder we need to backport to all those branches since the new version of linuxkit doesn't allow us to use those fields and we're updating to new linuxkit everywhere |
This was referenced Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove
security_optandportsfields frompkg/pillar/build-dev.ymlandpkg/pillar/build-k-dev.yml.These fields are Docker Compose-specific and have never been valid in linuxkit package
build.ymlfiles. They were silently ignored by older linuxkit versions. The upcoming linuxkit upgrade introduces strict YAML validation that rejects unknown fields, causing the build to fail with:This is a prerequisite cleanup before upgrading linuxkit to the latest version.
How to test and validate this PR
Run
make eve-pillarand verify the build completes without YAML validation errors.Changelog notes
No user-facing changes.
PR Backports
Checklist
I've provided a proper description
I've added the proper documentation
I've tested my PR on amd64 device
I've tested my PR on arm64 device
I've written the test verification instructions
I've set the proper labels to this PR
I've checked the boxes above, or I've provided a good reason why I didn't check them.