Skip to content

Makefile: let docker hash check ignore eden#5667

Merged
rene merged 1 commit intolf-edge:masterfrom
christoph-zededa:ignore_eden_dockerfiles
Mar 12, 2026
Merged

Makefile: let docker hash check ignore eden#5667
rene merged 1 commit intolf-edge:masterfrom
christoph-zededa:ignore_eden_dockerfiles

Conversation

@christoph-zededa
Copy link
Copy Markdown
Contributor

@christoph-zededa christoph-zededa commented Mar 11, 2026

Description

make eden creates several Dockerfiles under dist/; these can be ignored when running
make check-docker-hashes-consistency

How to test and validate this PR

  1. Run make eden
  2. Run make check-docker-hashes-consistency

no inconsistencies for dist/ should be found

Changelog notes

Internal improvement

PR Backports

For all current LTS branches, please state explicitly if this PR should be
backported or not. This section is used by our scripts to track the backports,
so, please, do not omit it.

Here is the list of current LTS branches (it should be always up to date):

  • 16.0-stable: no
  • 14.5-stable: no
  • 13.4-stable: no

Checklist

  • I've provided a proper description
  • I've added the proper documentation
  • I've tested my PR on amd64 device
  • I've tested my PR on arm64 device
  • I've written the test verification instructions
  • I've set the proper labels to this PR

And the last but not least:

  • I've checked the boxes above, or I've provided a good reason why I didn't
    check them.

Please, check the boxes above after submitting the PR in interactive mode.

`make eden` creates several Dockerfiles under dist/
these can be ignored when running
`make check-docker-hashes-consistency`

Signed-off-by: Christoph Ostarek <christoph@zededa.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 29.49%. Comparing base (2281599) to head (0232e48).
⚠️ Report is 336 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5667      +/-   ##
==========================================
+ Coverage   19.52%   29.49%   +9.96%     
==========================================
  Files          19       18       -1     
  Lines        3021     2417     -604     
==========================================
+ Hits          590      713     +123     
+ Misses       2310     1552     -758     
- Partials      121      152      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@rene rene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rene rene merged commit d878d52 into lf-edge:master Mar 12, 2026
65 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants