zedagent: report EtcdSnapshot optional capability#5719
zedagent: report EtcdSnapshot optional capability#5719eriknordmark merged 1 commit intolf-edge:masterfrom
Conversation
github-actions
Bot
requested review from
OhmSpectator,
eriknordmark and
uncleDecart
|
PR #5698 is now merged. Go ahead and rebase on master. |
zedi-pramodh
force-pushed
the
set-etcdsnapshot-support
branch
from
d88234d to
abcaaf5
Compare
zedi-pramodh
changed the title
|
Fixed commit lint message and rebased to master. |
eriknordmark
left a comment
eriknordmark
left a comment
There was a problem hiding this comment.
This doesn't build at all - please check your own PRs for failures!
0.126 Running go vet
0.135 go vet ./...
2.422 # github.com/lf-edge/eve/pkg/pillar/cmd/zedagent
2.422 cmd/zedagent/reportinfo.go:1143:3: unknown field EtcdSnapshot in struct literal of type info.OptionalCapabilities
2.551 # github.com/lf-edge/eve/pkg/pillar/cmd/zedagent
2.551 # [github.com/lf-edge/eve/pkg/pillar/cmd/zedagent]
2.551 vet: cmd/zedagent/reportinfo.go:1143:3: unknown field EtcdSnapshot in struct literal of type info.OptionalCapabilities
2.733 make: *** [Makefile:135: vet] Error 1
For eve-k it will be true. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Pramodh Pallapothu <pramodh@zededa.com>
zedi-pramodh
force-pushed
the
set-etcdsnapshot-support
branch
from
abcaaf5 to
9d779db
Compare
|
Rebased to master again and recompiled fine. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5719 +/- ##
==========================================
+ Coverage 19.52% 28.34% +8.81%
==========================================
Files 19 18 -1
Lines 3021 2417 -604
==========================================
+ Hits 590 685 +95
+ Misses 2310 1588 -722
- Partials 121 144 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
Send the optional capability etcdsnapshot support for eve. In eve-k builds it's always true.
This PR depends on PR #5698
This PR fails to compile until PR5698 is merged.
How to test and validate this PR
eve-k devices now publish this capability which is used by controllers to provide the etcd snapshot functionality for Kubernetes clusters.
Changelog notes
Users can see etcd snapshot and rollback functionality for kubernetes clusters.
Checklist
And the last but not least:
check them.
Please, check the boxes above after submitting the PR in interactive mode.