Fix bootstrap config failing on missing ECDH cert#5775
Merged
eriknordmark merged 1 commit intolf-edge:masterfrom Apr 9, 2026
Merged
Fix bootstrap config failing on missing ECDH cert#5775eriknordmark merged 1 commit intolf-edge:masterfrom
eriknordmark merged 1 commit intolf-edge:masterfrom
Conversation
Commit d28f531 renamed VerifySigningCertChain to VerifyLeavesCertChain and added a check requiring an ECDH exchange certificate to be present. The bootstrap config verification was updated to call this new function, but BootstrapConfig.ControllerCerts only contains a signing cert chain and never includes an ECDH cert, causing bootstrap config loading to always fail with "failed to acquire ECDH cert". Make the ECDH requirement optional via a requireECDH parameter. The bootstrap config path passes false (signing cert only), while the normal controller cert paths (fetched from /certs endpoint and used for auth container verification) pass true. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Milan Lenco <milan@zededa.com>
github-actions
Bot
requested review from
OhmSpectator,
christoph-zededa and
uncleDecart
9 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5775 +/- ##
===========================================
+ Coverage 19.52% 29.87% +10.34%
===========================================
Files 19 18 -1
Lines 3021 2417 -604
===========================================
+ Hits 590 722 +132
+ Misses 2310 1549 -761
- Partials 121 146 +25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eriknordmark
approved these changes
Apr 8, 2026
Contributor
eriknordmark
left a comment
eriknordmark
left a comment
There was a problem hiding this comment.
Thanks for finding and fixing this. I'll add it to the backport PRs.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Commit d28f531 (PR #5584) renamed
VerifySigningCertChaintoVerifyLeavesCertChainand added a check requiring an ECDH exchange certificate to be present. The bootstrap config verification was updated to call this new function, butBootstrapConfig.ControllerCertsonly contains a signing cert chain and never includes an ECDH cert, causing bootstrap config loading to always fail withfailed to acquire ECDH cert.Make the ECDH requirement optional via a
requireECDHparameter. The bootstrap config path passesfalse(signing cert only), while the normal controller cert paths (fetched from/certsendpoint and used for auth container verification) passtrue.How to test and validate this PR
Install EVE OS using an installer with a baked-in bootstrap configuration (aka “single-use EVE installer”) on a device that requires a static IP (or proxy configuration, or VLAN subinterface) to reach the controller. Power on the device and verify that it successfully onboards.
PR Backports
Should be included in the backports for the PR: #5584
Checklist