refactor(kubeapi): introduce WaitForKubernetesOptions to control optional waits#5799
Merged
rene merged 1 commit intolf-edge:masterfrom Apr 28, 2026
Merged
Conversation
github-actions
Bot
requested review from
OhmSpectator,
eriknordmark,
europaul,
jsfakian,
milan-zededa,
naiming-zededa,
rouming,
uncleDecart and
zedi-pramodh
andrewd-zededa
force-pushed
the
eve-k-domainmgr-boot-wait
branch
from
02a0294 to
eaca80a
Compare
Contributor
Author
|
back to draft while resolving single node fix |
andrewd-zededa
force-pushed
the
eve-k-domainmgr-boot-wait
branch
from
eaca80a to
49182d7
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5799 +/- ##
==========================================
- Coverage 19.52% 17.13% -2.40%
==========================================
Files 19 474 +455
Lines 3021 85591 +82570
==========================================
+ Hits 590 14664 +14074
- Misses 2310 69412 +67102
- Partials 121 1515 +1394 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrewd-zededa
force-pushed
the
eve-k-domainmgr-boot-wait
branch
from
49182d7 to
be0c660
Compare
Contributor
Author
|
Rebased on latest master |
andrewd-zededa
force-pushed
the
eve-k-domainmgr-boot-wait
branch
2 times, most recently
from
fe371fc to
3b51de0
Compare
…diness - Add WaitForKubernetesOptions with WaitForKubevirt and WaitForLonghorn flags; replace KubevirtPodsRunning pod-count heuristic and registrationAppliedToCluster guards with explicit caller-supplied opts - Extract waitForKubevirtReady to check KubeVirt CR Available=True condition; slim waitForNodeReady to a one-shot node-existence gate that gates optional component checks; move PollImmediate loop into WaitForKubernetes goroutine - WaitForKubernetes now propagates errors (was always nil) - domainmgr subscribes EdgeNodeClusterConfig to resolve ClusterType; sets WaitForKubevirt only for ClusterTypeReplicatedStorage and retries WaitForKubernetes indefinitely when kubevirt readiness is required - Bound all API calls in the wait path with kubeAPITimeout context Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Andrew Durbin <andrewd@zededa.com>
andrewd-zededa
force-pushed
the
eve-k-domainmgr-boot-wait
branch
from
3b51de0 to
87d5c50
Compare
Contributor
Author
|
Rebased on latest master and refined waitForKubevirt flag in domainmgr.go Run() and waitForLhFlag in volumemgr.go Run(). Both check for the updated EdgeNodeClusterConfig behavior (checking the Valid structure member boolean). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
WaitForKubernetesOptionsstruct withWaitForKubevirtandWaitForLonghornboolean flags, replacing implicitregistrationAppliedToCluster()guards insideWaitForKubernetes.domainmgrandvolumemgrnow subscribe toEdgeNodeClusterConfig(60 s timeout) before calling
WaitForKubernetesand set only the flagrelevant to their role.
check on the KubeVirt CR
Available=Truecondition.PR dependencies
None
How to test and validate this PR
ReplicatedStorage cluster (KubeVirt + Longhorn waits active).
(neither wait is triggered).
WaitForKubernetesOptions{}.triggers a warning log and proceeds without blocking.
Changelog notes
None
PR Backports
Checklist
And the last but not least:
check them.
Please, check the boxes above after submitting the PR in interactive mode.