Skip to content

Disable app logs and set Firmware UUID#5817

Merged
rene merged 1 commit intolf-edge:masterfrom
zedi-pramodh:add-firmware-uuid
Apr 28, 2026
Merged

Disable app logs and set Firmware UUID#5817
rene merged 1 commit intolf-edge:masterfrom
zedi-pramodh:add-firmware-uuid

Conversation

@zedi-pramodh
Copy link
Copy Markdown

This commit addresses couple of issues.

  1. If DisableLogs was set in DomainConfig, then do not start guest-console container.
  2. Always pass in app UUID as Firmware UUID. That is required for some apps to keep license during failover.

How to test and validate this PR

  1. Disable app logging in controller and verify logs are not shown and vice versa
  2. Install FireWall app, register the license with app Firmware UUID, do failovers and verify license is not corrupted.

Changelog notes

None

Checklist

  • I've provided a proper description

  • I've added the proper documentation

  • I've tested my PR on amd64 device

  • I've written the test verification instructions

  • I've set the proper labels to this PR

  • I've checked the boxes above, or I've provided a good reason why I didn't
    check them.

Please, check the boxes above after submitting the PR in interactive mode.

Copy link
Copy Markdown
Contributor

@naiming-zededa naiming-zededa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rene
Copy link
Copy Markdown
Contributor

rene commented Apr 17, 2026

@zedi-pramodh
Copy link
Copy Markdown
Author

That's strange, I was able to compile and deploy at customer. Let me check if I missed something to merge

@zedi-pramodh
Copy link
Copy Markdown
Author

Sorry my bad. I fixed the missing import and rebased to master and compiled.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.68%. Comparing base (2281599) to head (26a5017).
⚠️ Report is 518 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5817      +/-   ##
==========================================
+ Coverage   19.52%   25.68%   +6.15%     
==========================================
  Files          19       24       +5     
  Lines        3021     4213    +1192     
==========================================
+ Hits          590     1082     +492     
- Misses       2310     2911     +601     
- Partials      121      220      +99     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zedi-pramodh
Copy link
Copy Markdown
Author

Rebased, resolved conflicts.

Copy link
Copy Markdown
Contributor

@andrewd-zededa andrewd-zededa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @zedi-pramodh could a change be made to migrate the logging config of exiting VMI app instances?

@andrewd-zededa
Copy link
Copy Markdown
Contributor

I think another rebase may resolve the go test failure

@zedi-pramodh
Copy link
Copy Markdown
Author

LGTM, @zedi-pramodh could a change be made to migrate the logging config of exiting VMI app instances?

Sorry I did not understand this comment.

This commit addresses couple of issues.
1) If DisableLogs was set in DomainConfig, then do not start guest-console container.
2) Always pass in app UUID as Firmware UUID. That is required for some apps to keep license during failover.

Signed-off-by: Pramodh Pallapothu <pramodh@zededa.com>
@zedi-pramodh
Copy link
Copy Markdown
Author

Rebased again.

@andrewd-zededa
Copy link
Copy Markdown
Contributor

LGTM, @zedi-pramodh could a change be made to migrate the logging config of exiting VMI app instances?

Sorry I did not understand this comment.

My understanding is that this change will only set the logging config of newly created app instances and existing app instances will not change. Is it possible to patch the config of existing app instances to disable their logs? (only if controller config has it set)

@zedi-pramodh
Copy link
Copy Markdown
Author

My understanding is that this change will only set the logging config of newly created app instances and existing app instances will not change. Is it possible to patch the config of existing app instances to disable their logs? (only if controller config has it set)

It should work automatically right ? All existing apps will be restarted as part of eve-k upgrade so this change will be inherited by them.

Copy link
Copy Markdown
Contributor

@rene rene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kicking off tests...

@rene rene merged commit 4b30a72 into lf-edge:master Apr 28, 2026
38 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants