Disable app logs and set Firmware UUID#5817
Conversation
|
eve-k doesn't build with these changes: https://github.com/lf-edge/eve/actions/runs/24537469283/job/71736230637?pr=5817#step:4:2029 |
|
That's strange, I was able to compile and deploy at customer. Let me check if I missed something to merge |
ce4d331 to
26a5017
Compare
|
Sorry my bad. I fixed the missing import and rebased to master and compiled. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5817 +/- ##
==========================================
+ Coverage 19.52% 25.68% +6.15%
==========================================
Files 19 24 +5
Lines 3021 4213 +1192
==========================================
+ Hits 590 1082 +492
- Misses 2310 2911 +601
- Partials 121 220 +99 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
26a5017 to
3bbcc70
Compare
|
Rebased, resolved conflicts. |
andrewd-zededa
left a comment
There was a problem hiding this comment.
LGTM, @zedi-pramodh could a change be made to migrate the logging config of exiting VMI app instances?
|
I think another rebase may resolve the go test failure |
Sorry I did not understand this comment. |
This commit addresses couple of issues. 1) If DisableLogs was set in DomainConfig, then do not start guest-console container. 2) Always pass in app UUID as Firmware UUID. That is required for some apps to keep license during failover. Signed-off-by: Pramodh Pallapothu <pramodh@zededa.com>
3bbcc70 to
09bcbcc
Compare
|
Rebased again. |
My understanding is that this change will only set the logging config of newly created app instances and existing app instances will not change. Is it possible to patch the config of existing app instances to disable their logs? (only if controller config has it set) |
It should work automatically right ? All existing apps will be restarted as part of eve-k upgrade so this change will be inherited by them. |
This commit addresses couple of issues.
How to test and validate this PR
Changelog notes
None
Checklist
I've provided a proper description
I've added the proper documentation
I've tested my PR on amd64 device
I've written the test verification instructions
I've set the proper labels to this PR
I've checked the boxes above, or I've provided a good reason why I didn't
check them.
Please, check the boxes above after submitting the PR in interactive mode.