Simplify Longhorn_is_ready log gate flag, tmp file not needed.#5854
Merged
rene merged 1 commit intolf-edge:masterfrom Apr 25, 2026
Merged
Simplify Longhorn_is_ready log gate flag, tmp file not needed.#5854rene merged 1 commit intolf-edge:masterfrom
rene merged 1 commit intolf-edge:masterfrom
Conversation
Just a global var instead, also removes race in mktemp usage without -u. Temp file was writing before readiness was determined in some cases. Signed-off-by: Andrew Durbin <andrewd@zededa.com>
andrewd-zededa
force-pushed
the
eve-k-lh-rdy-tmp
branch
from
de225ff to
46ac792
Compare
andrewd-zededa
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Just a global var instead, also removes race in mktemp usage without -u. Temp file was writing before readiness was determined in some cases.
PR dependencies
None
How to test and validate this PR
Changelog notes
fix race in creating longhorn ds ready log entry
PR Backports
Checklist
And the last but not least:
check them.
Please, check the boxes above after submitting the PR in interactive mode.