Skip to content

eden-trusted: use eden master for EVE master CI#5855

Merged
rene merged 1 commit intolf-edge:masterfrom
eriknordmark:eden-master-pin
Apr 24, 2026
Merged

eden-trusted: use eden master for EVE master CI#5855
rene merged 1 commit intolf-edge:masterfrom
eriknordmark:eden-master-pin

Conversation

@eriknordmark
Copy link
Copy Markdown
Contributor

Summary

  • The tests-master job in eden-trusted.yml was pinned to eden tag 1.0.15, while eden master had moved two releases ahead (1.0.16 and beyond).
  • This caused smoketest failures on PRs against EVE master when the issue was in eden, not EVE itself.
  • Change the uses: ref for tests-master to @master so it always tracks eden master.
  • The three stable-branch jobs (tests-13-4-stable, tests-14-5-stable, tests-16-0-stable) remain pinned to @1.0.15 as those EVE branches require the older compatible eden version.

Test plan

  • Verify the failing smoketests in Fix lost NTP telemetry #5851 pass after this change
  • Verify stable-branch CI jobs still reference @1.0.15 and are unaffected

🤖 Generated with Claude Code

The smoketests for EVE master were pinned to eden tag
1.0.15, causing failures when eden master had fixes or
features not yet in that tag. The stable-branch jobs
remain pinned to 1.0.15 since they require the older
eden version compatible with those EVE releases.

Signed-off-by: eriknordmark <erik@zededa.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions github-actions Bot requested a review from uncleDecart April 23, 2026 21:53
@eriknordmark eriknordmark requested review from europaul and rene April 23, 2026 21:54
@europaul
Copy link
Copy Markdown
Contributor

europaul commented Apr 24, 2026

@eriknordmark only the workflow file is checked out on 1.0.15, the rest of the eden repo incl tests is checked out on master.
I'm not against this change, but it will not solve any failing tests. The only change to the workflow file since 1.0.15 is lf-edge/eden@709f514 - and it doesn't solve anything.

Copy link
Copy Markdown
Contributor

@rene rene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@europaul , I think it still makes sense to fetch test from master, we might have future changes only intend for master, so I think this keeps more "alignment" and also avoid confusions...

@rene rene merged commit 3caf33a into lf-edge:master Apr 24, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants