eve-k: update to kubevirt 1.7.3#5865
Conversation
Update stale expected_versions for update path up to the expected running versions defined in kube currently. Signed-off-by: Andrew Durbin <andrewd@zededa.com>
kubevirt.io/api and kubevirt.io/client-go bumped from v1.6.0 -> v1.7.3 in pkg/pillar, and from v1.2.0 -> v1.7.3 in pkg/kube/update-component. kubevirt v1.7.3 requires k8s.io/client-go v0.33.5 which introduced the k8s.io/client-go/kubernetes/typed/resource/v1beta2 package for the DRA (Dynamic Resource Allocation) v1beta2 API. That package does not exist in v0.32.5, so go mod tidy failed until the k8s.io/* pins were raised. pkg/pillar changes: - kubevirt.io/api: v1.6.0 -> v1.7.3 - kubevirt.io/client-go: v1.6.0 -> v1.7.3 - All k8s.io/* replace directives: v0.32.5 -> v0.33.5 - kubevirt.io/containerized-data-importer-api updated to v1.63.1 - go.sum and vendor/ regenerated pkg/kube/update-component changes: - kubevirt.io/client-go: v1.2.0 -> v1.7.3 (larger jump) - All k8s.io/* replace directives: v0.26.3 -> v0.33.5 - k8s.io/kube-openapi pseudo-version updated to align with kubevirt pin - kubevirt.io/containerized-data-importer-api updated to v1.63.1 - go.sum and vendor/ regenerated API breakage fix in pkg/kube/update-component/kubevirt.go: - KubeVirt().Get() signature changed in v1.7.3: context.Context is now required as the first argument, and GetOptions is passed by value instead of by pointer. Updated the single call site accordingly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Andrew Durbin <andrewd@zededa.com>
|
Nothing to review here all clean and good :) BTW, did you test cluster upgrade with this PR ? |
I did upgrade my dev cluster from master with 1.6.0 to this build including 1.7.3. The kubevirt component is updated after the first node in the cluster boots into the new eve baseos version. Watch kubevirt component update process in k3s-install.log: and confirm kubevirt new version like this in 'eve enter kube': |
|
LGTM. @rene can we get this merged by Monday so that we can provide build to a customer, thanks |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5865 +/- ##
==========================================
- Coverage 19.52% 17.03% -2.50%
==========================================
Files 19 477 +458
Lines 3021 85762 +82741
==========================================
+ Hits 590 14611 +14021
- Misses 2310 69641 +67331
- Partials 121 1510 +1389 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I can't be merged while it is marked as a draft @naiming-zededa |
@andrewd-zededa can you remove the draft, is this done? |
|
One small line addition to make, will push in about an hour |
Exit if KUBE_VERSION below current applied version. Don't try downgrades, unsupported. Signed-off-by: Andrew Durbin <andrewd@zededa.com>
d5c052b to
0eaa874
Compare
Description
Incorporate bug fixes in the 1.7.3 release regarding VMI reporting stuck in Pending due to an issue in the virt-handler pod notification server.
KUBE_VERSION moved to 3 to trigger updates. Downgrade blocking gate added in cluster-update.sh: just exit if applied-kube-version is greater than current script version KUBE_VERSION.
Large PR due to all the go mod dependency updates needed to update the kubevirt go mod to 1.7.3 as well
Go Mod Changes:
kubevirt.io/api and kubevirt.io/client-go bumped from v1.6.0 -> v1.7.3
in pkg/pillar, and from v1.2.0 -> v1.7.3 in pkg/kube/update-component.
kubevirt v1.7.3 requires k8s.io/client-go v0.33.5 which introduced the
k8s.io/client-go/kubernetes/typed/resource/v1beta2 package for the DRA
(Dynamic Resource Allocation) v1beta2 API. That package does not exist
in v0.32.5, so go mod tidy failed until the k8s.io/* pins were raised.
pkg/pillar changes:
pkg/kube/update-component changes:
API breakage fix in pkg/kube/update-component/kubevirt.go:
required as the first argument, and GetOptions is passed by value
instead of by pointer. Updated the single call site accordingly.
PR dependencies
None
How to test and validate this PR
Changelog notes
Update kubevirt to 1.7.3 to incorporate VMI ready fix
PR Backports
Checklist
And the last but not least:
check them.
Please, check the boxes above after submitting the PR in interactive mode.