github/workflows: Add codecov to publish workflow#5871
github/workflows: Add codecov to publish workflow#5871eriknordmark merged 2 commits intolf-edge:masterfrom
Conversation
Codecov action on go-tests doesn't upload results since a token is required. As a consequence, the action will not have updated results to compare. This commit introduces the codecov in the publish workflow. It will run go-tests and upload the results with the token provided in the repository secrets. Thus, the codecov from regular go-tests will be able to fetch updated results. Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
rene
force-pushed
the
add-codevcov-pub
branch
5 times, most recently
from
54ffc61 to
26d3509
Compare
Fix actionlint errors on publish.yml. Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
| docker rmi -f $(docker image ls -q) || : | ||
| docker system prune -f -a || : | ||
| docker rm -f $(docker ps -aq) && docker volume rm -f $(docker volume ls -q) || : | ||
| docker system prune -f -a --volumes |
There was a problem hiding this comment.
Does --volumes prune containers or do you also need a docker system prune -f?
There was a problem hiding this comment.
@eriknordmark , I'm just porting the commands we use on build workflow: e471303
After the fixes on linuxkit I think these are good enough. It works for the build workflow and on a partial test it also works for publish on my repo.
| make clean | ||
| docker system prune -f -a --volumes | ||
| rm -rf ~/.linuxkit |
There was a problem hiding this comment.
The original code ignored any failures. Don't we still need such ignore here and in the other cleanup code?
There was a problem hiding this comment.
As I said on the other comment, I don't think we need to ignore after the linuxkit fixes. The commands are executed fine now.
eriknordmark
left a comment
eriknordmark
left a comment
There was a problem hiding this comment.
@rene see comments and questions.
Kicking off any remaining tests.
2 participants
Description
Codecov action on go-tests doesn't upload results since a token is required. As a consequence, the action will not have updated results to compare. This commit introduces the codecov in the publish workflow. It will run go-tests and upload the results with the token provided in the repository secrets. Thus, the codecov from regular go-tests will be able to fetch updated results.
Partially tested on: https://github.com/rene/eve/actions/runs/24932456960/job/73012348318#step:9:1
How to test and validate this PR
Run publish workflow.
Changelog notes
None.
PR Backports
Checklist
check them.