Skip to content

bpftrace-compiler: add vendoring#5877

Merged
rene merged 1 commit intolf-edge:masterfrom
christoph-zededa:bpftrace_compiler_helper_add_vendoring
Apr 30, 2026
Merged

bpftrace-compiler: add vendoring#5877
rene merged 1 commit intolf-edge:masterfrom
christoph-zededa:bpftrace_compiler_helper_add_vendoring

Conversation

@christoph-zededa
Copy link
Copy Markdown
Contributor

@christoph-zededa christoph-zededa commented Apr 28, 2026

Description

hopefully this helps against flakiness of the CI as we experience sometimes the following error:

27 [bpftrace 16/17] RUN CGO_ENABLED=0 GOARCH=${TARGETARCH} go build -o /bpftrace-helper
27 0.634 go: downloading github.com/pmorjan/kmod v1.1.1
27 0.637 go: downloading golang.org/x/sync v0.16.0
27 2.134 go: downloading golang.org/x/sys v0.35.0
coverage: 26.6% of statements
panic: test timed out after 5h0m0s
	running tests:
		TestCurrentKernels (4h24m51s)

How to test and validate this PR

Run tests on our CI repeatedly and not experiencing the above issue.

Changelog notes

Internal improvement for our CI.

PR Backports

For all current LTS branches, please state explicitly if this PR should be
backported or not. This section is used by our scripts to track the backports,
so, please, do not omit it.

Here is the list of current LTS branches (it should be always up to date):

  • 16.0-stable: no, as this only improves testing
  • 14.5-stable: no
  • 13.4-stable: no

Also, to the PRs that should be backported into any stable branch, please
add a label stable.

Checklist

  • I've provided a proper description
  • I've added the proper documentation
  • I've tested my PR on amd64 device
  • I've tested my PR on arm64 device
  • I've written the test verification instructions
  • I've set the proper labels to this PR

And the last but not least:

  • I've checked the boxes above, or I've provided a good reason why I didn't
    check them.

Please, check the boxes above after submitting the PR in interactive mode.

@github-actions github-actions Bot requested a review from eriknordmark April 28, 2026 15:50
@christoph-zededa christoph-zededa force-pushed the bpftrace_compiler_helper_add_vendoring branch 3 times, most recently from 0bd8a59 to 05f778d Compare April 28, 2026 16:37
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.12%. Comparing base (2281599) to head (753c643).
⚠️ Report is 630 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5877      +/-   ##
==========================================
- Coverage   19.52%   17.12%   -2.41%     
==========================================
  Files          19      474     +455     
  Lines        3021    85606   +82585     
==========================================
+ Hits          590    14661   +14071     
- Misses       2310    69429   +67119     
- Partials      121     1516    +1395     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rene
Copy link
Copy Markdown
Contributor

rene commented Apr 29, 2026

@christoph-zededa , go-tests passed. Is this a good indication that it works? Can we mark the PR as ready for review?

hopefully this helps against flakiness of the CI as we
experience sometimes the following error:
```
27 [bpftrace 16/17] RUN CGO_ENABLED=0 GOARCH=${TARGETARCH} go build -o /bpftrace-helper
27 0.634 go: downloading github.com/pmorjan/kmod v1.1.1
27 0.637 go: downloading golang.org/x/sync v0.16.0
27 2.134 go: downloading golang.org/x/sys v0.35.0
coverage: 26.6% of statements
panic: test timed out after 5h0m0s
	running tests:
		TestCurrentKernels (4h24m51s)
```

Signed-off-by: Christoph Ostarek <christoph@zededa.com>
@christoph-zededa christoph-zededa force-pushed the bpftrace_compiler_helper_add_vendoring branch from 05f778d to 753c643 Compare April 29, 2026 09:50
@christoph-zededa
Copy link
Copy Markdown
Contributor Author

/rerun red

@christoph-zededa christoph-zededa marked this pull request as ready for review April 29, 2026 14:21
@christoph-zededa
Copy link
Copy Markdown
Contributor Author

@christoph-zededa , go-tests passed. Is this a good indication that it works? Can we mark the PR as ready for review?

I also added the vendor files for bptrace-compiler, not only the tool that is used by bpftrace-compiler.
It is an indication that it works.
Marked it as "Ready for Review" now.

@christoph-zededa christoph-zededa changed the title bpftrace-helper: add vendoring bpftrace-compiler: add vendoring Apr 29, 2026
@rene
Copy link
Copy Markdown
Contributor

rene commented Apr 30, 2026

Happy to see Yetus green for a PR with more than 3k files!

@rene
Copy link
Copy Markdown
Contributor

rene commented Apr 30, 2026

And Go-Tests green as well, of course!

@rene rene merged commit 543ce87 into lf-edge:master Apr 30, 2026
31 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants