Make sure SenderStatusCertMiss is not overwritten#5906
Make sure SenderStatusCertMiss is not overwritten#5906eriknordmark merged 1 commit intolf-edge:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5906 +/- ##
==========================================
- Coverage 19.52% 17.10% -2.43%
==========================================
Files 19 474 +455
Lines 3021 85692 +82671
==========================================
+ Hits 590 14657 +14067
- Misses 2310 69516 +67206
- Partials 121 1519 +1398 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| // prepare intermediate certs and validate the payload | ||
| var signCertBytes []byte | ||
| var keyCnt, signKeyCnt, encrKeyCnt int | ||
| interm := x509.NewCertPool() |
There was a problem hiding this comment.
Let's take this opportunity to fix these Yetus issues....
There was a problem hiding this comment.
@rene
Why? This is a priority 1 bug AFAICT.
This is needed to fetch new controller certificates. Signed-off-by: eriknordmark <erik@zededa.com>
|
Storage (zfs) is consistently timing out: https://github.com/lf-edge/eve/actions/runs/25430843709/job/74686298784#step:4:1011 Perhaps you could increase from 10min to 20min? |
Exploring ways to make that more robust in lf-edge/eden#1155, which is undoing/redoing a previous attempt to fix another issue in the ZFS storage test. |
https://github.com/lf-edge/eden/actions/runs/25460237740/job/74700236782?pr=1155 is looking good so merging this PR and those Storage(zfs) tests will become more robust with 1155. |
Description
This is needed to fetch new controller certificates. Without it certificate rotation can fail to propagate to
EVE devices in a timely manner (the 24 h timer will do it as a fallback).
Fixes the failures we see in the ctrl_cert_change test.
This was introduced in #5584 but the manual testing of those fixes always had a .bak file, and the eden smoke tests have had several cases of flaky tests preceeding the crtl_cert_change test so it has not been getting to the point of trying crtl_cert_change until recently.
How to test and validate this PR
Should be part of the normal regression testing, but in this case we need to run the manual
test which updates the controller signing certificate in addition to the eden test.
Changelog notes
None (part of the PR 5584)
PR Backports
MUST be backported where #5584 is backported wich is:
Checklist
I've provided a proper description
I've added the proper documentation
I've tested my PR on amd64 device
I've tested my PR on arm64 device
I've written the test verification instructions
I've set the proper labels to this PR
I've checked the boxes above, or I've provided a good reason why I didn't
check them.