Use generic Verity ergonomics in UnlinkPool#69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Circuitexternal-call returnsabiHeadWordslices withabiEncode txn.proofrealNullifiers ...in event argumentswith onlyRelayermodifier syntaxValidation
lake build Benchmark.Cases.UnlinkXyz.Pool.Compilelake buildNote
Medium Risk
Touches core
deposit/transfer/withdrawflows and proof/circuit external-call wiring; behavior should be equivalent but mismatched ABI encoding or circuit shape handling could break verification at runtime.Overview
Modernizes the
UnlinkPoolVerity model to use a typedCircuitstruct forgetCircuitresults (plus*_tryvariants), and updatestransfer/executeWithdrawalto validate input/output shapes and circuit status viacircuit.*fields.Refactors ZK proof verification calls to pass
abiEncode txn.proofinstead of manualabiHeadWordslicing, and simplifies event emission by inliningrealNullifierscomputation.Replaces per-call-site relayer checks with a shared
modifier onlyRelayerand applies it viawith onlyRelayeron relayer-gated entrypoints. Updates the pinnedveritydependency revision inlakefile.lean/lake-manifest.json.Reviewed by Cursor Bugbot for commit d94775d. Bugbot is set up for automated code reviews on this repo. Configure here.