fix:: throw error when passing incompatible arguments to subroutines #8722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
certik
approved these changes
Oct 15, 2025
| std::string param_type_str = ASRUtils::type_to_str_fortran_expr(param_type, nullptr); | ||
| diag.add(diag::Diagnostic( | ||
| "Type mismatch in argument `" + std::string(v->m_name) + | ||
| ": expected `" + param_type_str + "` but got `" +passed_type_str + "`", |
Contributor
There was a problem hiding this comment.
Suggested change
| ": expected `" + param_type_str + "` but got `" +passed_type_str + "`", | |
| "`: expected `" + param_type_str + "` but got `" +passed_type_str + "`", |
Contributor
Author
|
The error is due to unable to access 'https://github.com/jinangshah21/fortran-shlex.git/': Could not resolve host: github.com Although it's second time this same error has occurred here |
certik
reviewed
Oct 16, 2025
src/libasr/codegen/asr_to_llvm.cpp
Outdated
|
|
||
| void handle_print(ASR::expr_t* arg, ASR::expr_t* end_expr) | ||
| { | ||
| std::printf("Inside print Arg Typ %d Enf Expr Type %d \n", arg->type, (end_expr != nullptr) ? end_expr->type : -1); |
Contributor
There was a problem hiding this comment.
This should not be here. You can notice by the huge change in reference tests.
Contributor
Author
There was a problem hiding this comment.
Oh! Extremely sorry for the troubles.
certik
approved these changes
Oct 17, 2025
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8719 addressing comments of #8720
Added Test-Case:
Updated Main:
Gfortran: