Fix: allow functions' return type to use variables from host scope #8741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
For arrays we insert autogenerated simple functions to handle this case. For strings it looks like we just link the global variable directly for subroutines (that already work), so this PR just follows the same design, which is fine for now. |
certik
reviewed
Oct 23, 2025
src/libasr/asr_verify.cpp
Outdated
| if (is_a<ASR::Variable_t>(*s) && is_a<ASR::ExternalSymbol_t>(*x.m_v)) { | ||
|
|
||
| // Allow any variable that is either external or is not defined in this scope to pass FunctionType verification | ||
| if (is_a<ASR::Variable_t>(*s) && (is_a<ASR::ExternalSymbol_t>(*x.m_v) || !current_symtab->get_symbol(x_mv_name))) { |
Contributor
There was a problem hiding this comment.
Only do it for strings --- check that the type is a character. Disallow for anything else.
…unctions_51 integartion tests
certik
reviewed
Oct 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8686
I did the following changes:
extract_lenfunction to remove any unused cases.visit_FunctionTypeverification check to allow using any variables that are either external or defined in a parent scope.