Feat!: GitHub/Gerrit closed loop testing fixes by ModeSevenIndustrialSolutions · Pull Request #58 · lfreleng-actions/github2gerrit-action

ModeSevenIndustrialSolutions · 2025-12-04T10:35:27Z

Feat!: GitHub/Gerrit closed loop testing fixes

Abandoned Gerrit changes are now closed automatically in GitHub
Closed/superceded GitHub pull requests are now closed in Gerrit

Also:

Converted some INFO messages to DEBUG to reduce console/job output noise
Fixed max_workers calculation when no work to perform
Ensure full/complete exception error propagation
Test isolation improvements related to processing changes
Minor markdown formatting/linting updates in documentation
Various output message/console logging updates/improvements
Minor changes to typer/exception handling and exit status
Filter HTML and markdown when copying Github comments to Gerrit

Flow/logic was optimised to:

Reconcile first: Determine reuse_ids before preparing commits
Single preparation: Prepare commits once with correct reuse_ids

Breaking change due to change in default behaviour:

ALLOW_DUPLICATES now default set true

Copilot

Pull request overview

Copilot reviewed 30 out of 31 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ModeSevenIndustrialSolutions · 2026-01-06T17:24:53Z

Tested here:
https://github.com/lfit/sandbox/actions/runs/20754622633/job/59593147679

Also see:
lfit/sandbox#37

Run # Run github2gerrit Python CLI
Running:python -m github2gerrit.cli
🏷️  github2gerrit version 0.0.0+dev
                       GitHub2Gerrit Configuration                       
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃ Property                  ┃ Value                                     ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┩
│ GITHUB_MODE               │ ✅ GitHub Actions mode                    │
│ USE_PR_AS_COMMIT          │ True                                      │
│ GERRIT_SSH_USER_G2G       │ lfit.gh2gerrit                            │
│ GERRIT_SSH_USER_G2G_EMAIL │ releng+lfit-gh2gerrit@linuxfoundation.org │
│ ORGANIZATION              │ lfit                                      │
│ PRESERVE_GITHUB_PRS       │ True                                      │
│ ISSUE_ID                  │ ❎ Not provided                           │
│ GERRIT_SERVER             │ gerrit.lfit.org                           │
│ GERRIT_KNOWN_HOSTS        │ ✅                                        │
│ GERRIT_SSH_PRIVKEY_G2G    │ ✅                                        │
│ GITHUB_TOKEN              │ ✅                                        │
│ SSH_AGENT                 │ ❎ Unavailable, Unused                    │
│ CLEANUP_ABANDONED         │ ☑️                                         │
│ CLEANUP_GERRIT            │ ☑️                                         │
└───────────────────────────┴───────────────────────────────────────────┘
🔄 Merged Gerrit change: 
https://gerrit.linuxfoundation.org/infra/c/sandbox/+/74043
☑️ No action required: Gerrit change did NOT originate in GitHub
⛔️ Checking for abandoned Gerrit changes
               Abandoned Pull Request Details               
┏━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃ Property      ┃ Value                                    ┃
┡━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┩
│ Repository    │ lfit/sandbox                             │
│ PR Number     │ 37                                       │
│ Title         │ Chore: Second test                       │
│ Author        │ ModeSevenIndustrialSolutions             │
│ Base Branch   │ master                                   │
│ SHA           │ 351b7fea5efa8e59cbcdc15565ca7b69c748363e │
│ URL           │ https://github.com/lfit/sandbox/pull/37  │
│ Files Changed │ 2                                        │
└───────────────┴──────────────────────────────────────────┘
🛑 Closed pull request #37 with abandoned Gerrit change 74039

ModeSevenIndustrialSolutions · 2026-01-12T12:13:57Z

Needs: #100

- Abandoned Gerrit changes are now closed automatically in GitHub - Closed/superceded GitHub pull requests are now closed in Gerrit Also: - Converted some INFO messages to DEBUG to reduce console/job output noise - Fixed max_workers calculation when no work to perform - Ensure full/complete exception error propagation - Test isolation improvements related to processing changes - Minor markdown formatting/linting updates in documentation - Various output message/console logging updates/improvements - Minor changes to typer/exception handling and exit status - Filter HTML and markdown when copying Github comments to Gerrit Flow/logic was optimised to: 1. Reconcile first: Determine `reuse_ids` before preparing commits 2. Single preparation: Prepare commits once with correct `reuse_ids` Breaking changes due to change in default behaviour: - ALLOW_DUPLICATES default set from false -> true - SIMILARITY_FILES default set from false -> true ALLOW_DUPLICATES was primarily used during testing, has little effect in production workflows. SIMILARITY_FILES affects how commits are matched during pull request updates and changes reconcilliation behaviour. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>

Copilot

Pull request overview

Copilot reviewed 30 out of 30 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ModeSevenIndustrialSolutions self-assigned this Dec 4, 2025

Copilot AI review requested due to automatic review settings December 4, 2025 10:35

github-actions Bot added the feature label Dec 4, 2025

Copilot started reviewing on behalf of ModeSevenIndustrialSolutions December 4, 2025 10:35 View session

Copilot finished reviewing on behalf of ModeSevenIndustrialSolutions December 4, 2025 10:38

This comment was marked as outdated.

Sign in to view

ModeSevenIndustrialSolutions force-pushed the sync-updates branch from 62da060 to 028cb53 Compare December 4, 2025 11:27

ModeSevenIndustrialSolutions requested a review from Copilot December 4, 2025 11:29

Copilot started reviewing on behalf of ModeSevenIndustrialSolutions December 4, 2025 11:29 View session

Copilot finished reviewing on behalf of ModeSevenIndustrialSolutions December 4, 2025 11:32

This comment was marked as duplicate.

Sign in to view

ModeSevenIndustrialSolutions force-pushed the sync-updates branch 2 times, most recently from e5411ba to 993f715 Compare December 7, 2025 13:27

Copilot AI review requested due to automatic review settings December 7, 2025 13:27

Copilot started reviewing on behalf of ModeSevenIndustrialSolutions December 7, 2025 13:27 View session

This comment was marked as outdated.

Sign in to view

ModeSevenIndustrialSolutions force-pushed the sync-updates branch from 993f715 to 1d98999 Compare December 7, 2025 13:40

Copilot AI review requested due to automatic review settings December 7, 2025 13:53

ModeSevenIndustrialSolutions force-pushed the sync-updates branch from 1d98999 to 4c5c8e7 Compare December 7, 2025 13:53

Copilot started reviewing on behalf of ModeSevenIndustrialSolutions December 7, 2025 13:53 View session

This comment was marked as duplicate.

Sign in to view

ModeSevenIndustrialSolutions force-pushed the sync-updates branch from 4c5c8e7 to 423e1cd Compare December 7, 2025 14:06

Copilot AI review requested due to automatic review settings December 8, 2025 09:00

ModeSevenIndustrialSolutions force-pushed the sync-updates branch from 423e1cd to 63faf2b Compare December 8, 2025 09:00

Copilot started reviewing on behalf of ModeSevenIndustrialSolutions December 8, 2025 09:00 View session

This comment was marked as duplicate.

Sign in to view

ModeSevenIndustrialSolutions force-pushed the sync-updates branch from 63faf2b to 18ea5d6 Compare December 10, 2025 15:14

Copilot AI review requested due to automatic review settings December 17, 2025 18:16

ModeSevenIndustrialSolutions force-pushed the sync-updates branch from 18ea5d6 to 512f26a Compare December 17, 2025 18:16

Copilot started reviewing on behalf of ModeSevenIndustrialSolutions December 17, 2025 18:17 View session

ModeSevenIndustrialSolutions force-pushed the sync-updates branch from 8514a34 to 2b9b1fe Compare January 6, 2026 14:56

Copilot AI review requested due to automatic review settings January 6, 2026 14:56

Copilot started reviewing on behalf of ModeSevenIndustrialSolutions January 6, 2026 14:57 View session

This comment was marked as outdated.

Sign in to view

ModeSevenIndustrialSolutions force-pushed the sync-updates branch 2 times, most recently from 1545ba6 to 3cb26be Compare January 6, 2026 15:14

Copilot AI review requested due to automatic review settings January 6, 2026 15:14

Copilot started reviewing on behalf of ModeSevenIndustrialSolutions January 6, 2026 15:14 View session

Copilot AI reviewed Jan 6, 2026

View reviewed changes

Comment thread src/github2gerrit/core.py Outdated

ModeSevenIndustrialSolutions force-pushed the sync-updates branch 2 times, most recently from da9d630 to b7cc513 Compare January 6, 2026 15:56

Copilot AI review requested due to automatic review settings January 6, 2026 15:56

Copilot started reviewing on behalf of ModeSevenIndustrialSolutions January 6, 2026 15:56 View session

This comment was marked as outdated.

Sign in to view

ModeSevenIndustrialSolutions force-pushed the sync-updates branch 2 times, most recently from a6eea20 to 82ce1fe Compare January 6, 2026 16:19

Copilot AI review requested due to automatic review settings January 6, 2026 16:19

Copilot started reviewing on behalf of ModeSevenIndustrialSolutions January 6, 2026 16:19 View session

This comment was marked as outdated.

Sign in to view

ModeSevenIndustrialSolutions force-pushed the sync-updates branch from 82ce1fe to 59f7487 Compare January 6, 2026 17:18

Conversation

ModeSevenIndustrialSolutions commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as duplicate.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as duplicate.

Uh oh!

This comment was marked as duplicate.

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

ModeSevenIndustrialSolutions commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

ModeSevenIndustrialSolutions commented Jan 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ModeSevenIndustrialSolutions commented Dec 4, 2025 •

edited

Loading

ModeSevenIndustrialSolutions commented Jan 6, 2026 •

edited

Loading